Summary

Load admin site for Unit Tests, add form tests

Review Request #10339 — Created Nov. 29, 2018 and submitted Jan. 31, 2019, 10:36 a.m.

Information

Owner

skaefer143

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

58f3da5...

Reviewers

Groups

reviewboard, students

People

Description

The admin site models and URLs were unable to be accessed during Unit Tests.

This meant that if a test attempted to access an admin model page, the 

page would respond with a 404 error.
Adding django.contrib.admin.autodiscover() during initial test setup 

loads all the admin UI models, so tests have access to admin URLS.
DefaultReviewer form tests, WebhookTargetAdmin form tests, and OauthAdmin 

form tests were all added as well, to check that forms function as 

expected.

Testing Done

Running ./tests/runtests.py returns no errors. The form tests added
pass.

Issues

Description	From	Last Updated
Summary doesn't need a period. Also, can you rewrite your summary to be ~52 characters?	brennie	Dec. 6, 2018, 7:42 p.m.
Nit in the description: "during initial test setup allows all the models for the admin UI to load" -> "during …	shoven	Dec. 6, 2018, 9:19 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Add in autodiscover() function, as well as add remaining form tests.

Summary:

-	Test to see if admin site loads properly with ./test/runtests.py
+	Load admin site models and URLs during Unit Tests, add new form tests.

Description:

~		Test the ./test/runtests.py command, and test why the admin site doesn't properly load with this command.
	~	The admin site models and URLs were unable to be accessed during Unit Tests.
	+	This meant that if a test attempted to access an admin model page, the
	+	page would respond with a 404 error.
	+
	+	Adding `django.contrib.admin.autodiscover()` during initial test setup allows
	+	all the models for the admin UI to load, so tests have access to admin URLS.
	+
	+	DefaultReviewer form tests, WebhookTargetAdmin form tests, and OauthAdmin
	+	form tests were all added as well, to check that forms function as
	+	expected.

Testing Done:

	+	Running `./tests/runtests.py` returns no errors. The form tests added should
	+	pass.

Commit:

-	1b2423b54bc0b9ebf8fa0228cc3ae349d9640016
+	def9a94e7a6e4e0187f361792e33381d31273131

Diff:

Revision 2 (+126)

Show changes

	reviewboard/test.py
	reviewboard/notifications/tests/test_admin.py
	reviewboard/oauth/tests.py
	reviewboard/reviews/tests/test_admin.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

add in newline in test descriptions

Commit:

-	def9a94e7a6e4e0187f361792e33381d31273131
+	58f3da53e37486094b01f7e09cfa2cbf9779ac55

Diff:

Revision 3 (+129)

Show changes

	reviewboard/test.py
	reviewboard/notifications/tests/test_admin.py
	reviewboard/oauth/tests.py
	reviewboard/reviews/tests/test_admin.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Excellent change.
```

The issue has been resolved. Show all issues

Summary doesn't need a period.

Also, can you rewrite your summary to be ~52 characters?

Change Summary:

Change Summary

Summary:

-	Load admin site models and URLs during Unit Tests, add new form tests.
+	Load admin site for Unit Tests, add form tests

The issue has been resolved. Show all issues

Nit in the description: "during initial test setup allows all the models for the admin UI to load" -> "during initial test setup loads all the admin UI models" (I think this is more direct so it is a bit clearer)

Change Summary:

Updated Description

Description:

		The admin site models and URLs were unable to be accessed during Unit Tests.
		This meant that if a test attempted to access an admin model page, the
		page would respond with a 404 error.

~		Adding `django.contrib.admin.autodiscover()` during initial test setup allows
~		all the models for the admin UI to load, so tests have access to admin URLS.
	~	Adding `django.contrib.admin.autodiscover()` during initial test setup
	~	loads all the admin UI models, so tests have access to admin URLS.

		DefaultReviewer form tests, WebhookTargetAdmin form tests, and OauthAdmin
		form tests were all added as well, to check that forms function as
		expected.

Testing Done:

~		Running `./tests/runtests.py` returns no errors. The form tests added should
	~	Running `./tests/runtests.py` returns no errors. The form tests added
		pass.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (72e4c83)