Fix equality checking for signatures.

Review Request #10327 — Created Nov. 20, 2018 and submitted

Information

Django Evolution
master
67dc5d5...

Reviewers

This change defines a __ne__ for inequality checking, which is
necessary under Python 2.x (and the reason for some failed diffing that
was occurring). This just checks the inverse of __eq__.

It also fixes up most of the checks to ignore ordering in
OrderedDicts and most lists, so that two signatures can remain the
same even if, say, the order of fields changed.

Unit tests were added to ensure that all equality checks perform as
they're supposed to.

Unit tests pass.

Description From Last Updated

E127 continuation line over-indented for visual indent

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (5beaa7f)
Loading...