Summary

Fix inclusion of binary file changes in Perforce diffs.

Review Request #10326 — Created Nov. 19, 2018 and submitted Nov. 26, 2018, 11:32 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-1.0.x

Bugs

3659

Depends On

Commit

c09cb82...

Reviewers

Groups

rbtools

People

Description

The diff code for Perforce clients was mistakenly filtering out changes
to binary files. This change fixes it.

Testing Done

Created a perforce client with a change to a binary file. Before,
posting the changeset would show only the text files. After, it shows
the expected "This is a binary file" line in the diff viewer.

Issues

Description	From	Last Updated
We should explicitly check dl's value, or a false result becomes the value of dl ([] in this case).	chipx86	Nov. 24, 2018, 12:09 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/perforce.py (Diff revision 1)

The issue has been resolved. Show all issues

We should explicitly check dl's value, or a false result becomes the value of dl ([] in this case).

Commit:

e18c6b204fedf38d17801c6a693d7e6e9e756463

c09cb8204774a3ab8fca685b0136e5d5acd11c1b

Diff:

Revision 2 (+6 -2)

Show changes

rbtools/clients/perforce.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (c09cb82)