Fix inclusion of binary file changes in Perforce diffs.

Review Request #10326 — Created Nov. 19, 2018 and submitted

david
RBTools
release-1.0.x
3659
c09cb82...
rbtools

The diff code for Perforce clients was mistakenly filtering out changes
to binary files. This change fixes it.

Created a perforce client with a change to a binary file. Before,
posting the changeset would show only the text files. After, it shows
the expected "This is a binary file" line in the diff viewer.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
chipx86
  1. 
      
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     

    We should explicitly check dl's value, or a false result becomes the value of dl ([] in this case).

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (c09cb82)
Loading...