flake8
passed.
JSHint
passed.
Fix inclusion of binary file changes in Perforce diffs.
Review Request #10326 — Created Nov. 19, 2018 and submitted
The diff code for Perforce clients was mistakenly filtering out changes
to binary files. This change fixes it.
Created a perforce client with a change to a binary file. Before,
posting the changeset would show only the text files. After, it shows
the expected "This is a binary file" line in the diff viewer.
| Description | From | Last Updated |
|---|---|---|
|
We should explicitly check dl's value, or a false result becomes the value of dl ([] in this case). |
 chipx86
|
-
-
rbtools/clients/perforce.py (Diff revision 1) We should explicitly check
dl's value, or a false result becomes the value ofdl([]in this case).
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+6 -2) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.