• 
      

    Work with ProjectSignatures directly from the Version model.

    Review Request #10321 — Created Nov. 14, 2018 and submitted

    Information

    Django Evolution
    master
    0c7078e...

    Reviewers

    This introduces a new SignatureField class, which wraps all
    serialization/deserialization of project signatures, and updates the
    Version model to use it. Callers will now see the new signature
    objects, and won't need to worry about handling serialized data in any
    form. This gives us flexibility later to change the serialization format
    without breaking any callers.

    All code loading in or saving signature data has been updated to work
    with the new objects.

    Unit tests passed.

    Tested some basic evolution operations, which appeared to work. There's
    still further development needed to get everything into place.

    Description From Last Updated

    This seems unrelated to the rest of the change.

    daviddavid
    david
    1. 
        
    2. django_evolution/signature.py (Diff revision 1)
       
       
       
      Show all issues

      This seems unrelated to the rest of the change.

      1. Code in this change that previously was working with old signature data was updated to use ProjectSignature, and were testing for equality using this instead of utility calls to a standalone has_unique_together_changed. Since that was being removed, this comparison had to be fixed to ensure the logic still worked right.

      2. Got it.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (a53dcda)