JSHint
-
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 1) Show all issues
Review Request #10315 — Created Nov. 8, 2018 and updated
Information | |
---|---|
cdkushni | |
Review Board | |
release-4.0.x | |
e90a986... | |
Reviewers | |
reviewboard, students | |
Set up the view class for handling the popup dialog.
Need to remove old tooltip popup.
Handling basic popup functionality.
Handles comment selection from commentlist.
Selecting a comment will expand it to fill the dialog.
Replying in the dialog box (WIP) - Text field with action
buttons implemented, needs styling and reply posting.
Have issuebar inserted into comment when expanded.
Need to query user data from a comment to get avatars.
UI Design Aesthetics (WIP).
Description | From | Last Updated |
---|---|---|
There are a couple of places in your code with trailing whitespace |
|
|
Col: 21 Expected '===' and instead saw '=='. |
![]() |
|
Col: 7 'CommentTitleBarView' was used before it was defined. |
![]() |
|
Col: 11 'test' is defined but never used. |
![]() |
|
Col: 144 Missing semicolon. |
![]() |
|
Col: 34 Missing semicolon. |
![]() |
|
Col: 11 'urls' is defined but never used. |
![]() |
|
Col: 7 'CommentTitleBarView' was used before it was defined. |
![]() |
|
Col: 11 'timeStamp' is defined but never used. |
![]() |
|
Col: 11 'test' is defined but never used. |
![]() |
|
Col: 69 Missing semicolon. |
![]() |
|
Since this is an ES6 file you should be able to put a trailing comma after '_onMouseLeave' |
|
|
There seems to be some extra white space here. In addition to that on line 57 and 58, the ending ... |
|
|
Col: 11 'urls' is defined but never used. |
![]() |
|
Col: 7 'CommentTitleBarView' was used before it was defined. |
![]() |
|
Col: 11 'timeStamp' is defined but never used. |
![]() |
|
Col: 26 ['viewEl'] is better written in dot notation. |
![]() |
|
Col: 15 'reviewRequestEditor' is defined but never used. |
![]() |
|
Col: 7 'ReplyTextFieldView' is defined but never used. |
![]() |
|
Col: 11 'urls' is defined but never used. |
![]() |
|
Col: 16 Duplicate key 'comment'. |
![]() |
|
Col: 38 ['diffCommentsData'] is better written in dot notation. |
![]() |
|
Col: 38 ['rView'] is better written in dot notation. |
![]() |
|
Col: 7 'CommentTitleBarView' was used before it was defined. |
![]() |
|
Col: 15 'commentIssueManager' is defined but never used. |
![]() |
|
Col: 15 'interactive' is defined but never used. |
![]() |
|
Col: 15 'commentID' is defined but never used. |
![]() |
Description: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||
Diff: |
Revision 2 (+1047 -3) |
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 2) |
---|
Col: 7 'CommentTitleBarView' was used before it was defined.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 2) |
---|
Col: 11 'test' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 2) |
---|
Col: 144 Missing semicolon.
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+1180 -3) |
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 3) |
---|
Col: 34 Missing semicolon.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 3) |
---|
Col: 11 'urls' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 3) |
---|
Col: 7 'CommentTitleBarView' was used before it was defined.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 3) |
---|
Col: 11 'timeStamp' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 3) |
---|
Col: 11 'test' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 3) |
---|
Col: 69 Missing semicolon.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+1175 -3) |
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 4) |
---|
Col: 11 'urls' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 4) |
---|
Col: 7 'CommentTitleBarView' was used before it was defined.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 4) |
---|
Col: 11 'timeStamp' is defined but never used.
reviewboard/static/rb/js/views/abstractCommentBlockView.es6.js (Diff revision 4) |
---|
Since this is an ES6 file you should be able to put a trailing comma after '_onMouseLeave'
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 4) |
---|
There seems to be some extra white space here. In addition to that on line 57 and 58, the ending > for the <a> tag could be placed on the same line as the a tag itself. Additionally the closing </a> tag can be placed on a newline with the inner <input> tag being indented within the scope of the <a> section. For example look at what you did on lines 59-61 as it looks a bit nicer.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+2128 -12) |
reviewboard/static/rb/js/views/dlgReviewView.es6.js (Diff revision 5) |
---|
Col: 15 'reviewRequestEditor' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 7 'ReplyTextFieldView' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 11 'urls' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 16 Duplicate key 'comment'.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 38 ['diffCommentsData'] is better written in dot notation.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 38 ['rView'] is better written in dot notation.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 7 'CommentTitleBarView' was used before it was defined.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 15 'commentIssueManager' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 15 'interactive' is defined but never used.
reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 5) |
---|
Col: 15 'commentID' is defined but never used.