(WIP) Diff Comment Reply Pop Up Dialog

Review Request #10315 — Created Nov. 8, 2018 and updated

cdkushni
Review Board
release-4.0.x
18019b9...
reviewboard, students

Set up the view class for handling the popup dialog.
Need to remove old tooltip popup.
Handling basic popup functionality.
Handles comment selection from commentlist.
Selecting a comment will expand it to fill the dialog.
Replying in the dialog box (WIP) - Text field with action
buttons implemented, needs styling and reply posting.
Have issuebar inserted into comment when expanded.
Need to query user data from a comment to get avatars.
UI Design Aesthetics (WIP).



  • 7
  • 0
  • 3
  • 6
  • 16
Description From Last Updated
There are a couple of places in your code with trailing whitespace bolariinwa bolariinwa
Col: 7 'CommentTitleBarView' was used before it was defined. reviewbot reviewbot
Since this is an ES6 file you should be able to put a trailing comma after '_onMouseLeave' Malcolm Malcolm
There seems to be some extra white space here. In addition to that on line 57 and 58, the ending ... Malcolm Malcolm
Col: 11 'urls' is defined but never used. reviewbot reviewbot
Col: 7 'CommentTitleBarView' was used before it was defined. reviewbot reviewbot
Col: 11 'timeStamp' is defined but never used. reviewbot reviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

cdkushni
Review request changed

Description:

~  

Started by setting up the view class for handling the popup dialog.

~   Working on methods of handling multiple comment popup dialogs.

  ~

Set up the view class for handling the popup dialog.

  ~ Handling basic popup functionality(WIP).
  + Handles comment selection from commentlist.
  + Selecting a comment will expand it to fill the dialog.
  + Replying in the dialog box (WIP).
  + UI Design Aesthetics (WIP).

Commit:

-903f486f4981cb63e74c157f0fe383ab8853e611
+6b180fb93d3c6aa45803549283f51a4bef08bb3c

Diff:

Revision 2 (+1047 -3)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

bolariinwa
  1. 
      
  2. There are a couple of places in your code with trailing whitespace

  3. 
      
cdkushni
Review request changed

Description:

   

Set up the view class for handling the popup dialog.

~   Handling basic popup functionality(WIP).
  ~ Need to remove old tooltip popup.
  + Handling basic popup functionality.
    Handles comment selection from commentlist.
    Selecting a comment will expand it to fill the dialog.
~   Replying in the dialog box (WIP).
  ~ Replying in the dialog box (WIP) - Text field with action
  + buttons implemented, needs styling and reply posting.
  + Have issuebar inserted into comment when expanded.
  + Need to query user data from a comment to get avatars.
    UI Design Aesthetics (WIP).

Commit:

-6b180fb93d3c6aa45803549283f51a4bef08bb3c
+c7e59534a6144bfd7fb920aab304eb992bd0045d

Diff:

Revision 3 (+1180 -3)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

cdkushni
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

Malcolm
  1. 
      
  2. Since this is an ES6 file you should be able to put a trailing comma after '_onMouseLeave'

  3. reviewboard/static/rb/js/views/replyCommentDialogView.es6.js (Diff revision 4)
     
     
     
     
     
     
     

    There seems to be some extra white space here. In addition to that on line 57 and 58, the ending > for the <a> tag could be placed on the same line as the a tag itself. Additionally the closing </a> tag can be placed on a newline with the inner <input> tag being indented within the scope of the <a> section. For example look at what you did on lines 59-61 as it looks a bit nicer.

  4. 
      
Loading...