Summary

Fix rbt patch when applying patches from users with private profiles.

Review Request #10314 — Created Nov. 8, 2018 and submitted Nov. 24, 2018, 12:08 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-1.0.x

Bugs

Depends On

Commit

6e6f9f6...

Reviewers

Groups

rbtools

People

Description

If a user has marked their profile private, their full name and e-mail
address will be stripped from the API payloads. This would cause
rbt patch -c/-C to fail with an AttributeError when attempting to
create the commit.

This change fixes it so we create the commit as the running user.

Testing Done

Applied a patch from a user who had marked their profile private.

Issues

Description	From	Last Updated
This works but I feel there's room for improvement (maybe going forward, rather than right now). Mainly: There's duplicate logic …	chipx86	Nov. 16, 2018, 10:45 a.m.
This can be one statement.	chipx86	Nov. 16, 2018, 10:43 a.m.
This can be one statement.	chipx86	Nov. 16, 2018, 10:45 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

This works but I feel there's room for improvement (maybe going forward, rather than right now).

Mainly:

There's duplicate logic here, that's going to eventually become inconsistent as it gets duplicated further. It'd be really nice to have some centralized logic (maybe a utility method that can be called to figure all this out).
It'd be nice to also warn when we can't commit as the user, so it's not a surprise when they're not credited as the author in the commit. A centralized method can help with this.

david Nov. 16, 2018, 10:45 a.m.

I think I'd rather do that later. Right now there's no good place to put this, and the actual duplication is quite small. I will add logging.

rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one statement.
```
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one statement.
```