-
-
-
rbtools/postreview.py (Diff revision 1) Please add a doc string explaining what this does. Also, this should probably be get_submitted_changenum. Is that really what this is, though? It doesn't actually return a submitted version of a changenum. It's more that it determines whether it's pending or not and returns None if it's not... This seems like it would break existing Perforce setups where you have a pending changeset that isn't yet submitted. It would take the perfectly valid changenum and return None, which is not what we want. The *pending* check here and elsewhere in the code seems to really change the existing behavior, and we need to make sure it doesn't.
-
rbtools/postreview.py (Diff revision 1) It would be nice to make a function for returning the server version and then calling it here. It should return the version in a tuple, or some such, for easy comparison.
post-review: Support older p4d, pending changelists
Review Request #1031 — Created Sept. 9, 2009 and submitted
Information | |
---|---|
mw_triad | |
RBTools | |
Reviewers | |
rbtools | |
This fixes post-review to work on older p4d (which I am stuck with at $DAYJOB); without this change post-review can only be used on submitted changelists. This also adds support for the default changelist (for all p4/p4d versions). See also http://reviews.review-board.org/r/804/ (replacing the diffs there failed, hence the new request).
MW
Change Summary:
Add documentation, move server version lookup to its own function, unbreak _depot_to_local.
Diff: |
Revision 2 (+72 -12) |
---|
MW
Change Summary:
Store p4d_version when we do get_repository_info (saves some operations), and don't do extra work when we have the file list from 'p4 describe'.
Diff: |
Revision 3 (+71 -12) |
---|