Summary

Convert a few more views to ES6.

Review Request #10305 — Created Nov. 2, 2018 and submitted Nov. 29, 2018, 11:14 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

ee5c303...

Reviewers

Groups

reviewboard

People

Description

This change migrates the remaining files in rb/js/views/ to ES6 syntax
and features.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
This line is too long.	chipx86	Nov. 13, 2018, 4 p.m.
Wrong multi-line comment format.	chipx86	Nov. 13, 2018, 4 p.m.
Indented one level too far.	chipx86	Nov. 13, 2018, 4:01 p.m.
Array	chipx86	Nov. 13, 2018, 4:01 p.m.
This line's too long.	chipx86	Nov. 13, 2018, 4:01 p.m.
Space after arg name.	chipx86	Nov. 13, 2018, 4:01 p.m.
Can we spread this across lines?	chipx86	Nov. 13, 2018, 4:02 p.m.
For readability, can we move the nameToRow[fieldName] bit out into something like elIndex? Took me a minute to figure out …	chipx86	Nov. 13, 2018, 4:04 p.m.
Missing trailing comma.	chipx86	Nov. 13, 2018, 4:04 p.m.
Missing trailing comma.	chipx86	Nov. 13, 2018, 4:04 p.m.
Trailing comma?	chipx86	Nov. 13, 2018, 4:04 p.m.
Col: 27 'errorListEl' is defined but never used.	reviewbot	Nov. 13, 2018, 11:33 p.m.
I don't think we do this anywhere else for options. Instead, we list the individual options as optional if they …	chipx86	Nov. 21, 2018, 4:42 p.m.
There's no event parameter in this function.	chipx86	Nov. 29, 2018, 11:13 a.m.
Same here.	chipx86	Nov. 29, 2018, 11:13 a.m.

flake8 passed.

JSHint passed.

Change Summary:

Fix some small regressions

Commit:

3053751809353dad3d75245e55bc8963c1d51722

551650e6f496bfd577a93907a9ae6e8e7088ce29

Diff:

Revision 2 (+598 -503)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/floatingBannerView.js
	reviewboard/static/rb/js/views/headerView.js
	reviewboard/static/rb/js/views/revisionSelectorView.js
	reviewboard/static/rb/js/views/screenshotThumbnailView.js
	reviewboard/static/rb/js/views/starManagerView.js
	reviewboard/static/rb/js/views/updateDiffView.js
	reviewboard/static/rb/js/views/updateDiffView.es6.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/headerView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
This line is too long.
```
reviewboard/static/rb/js/views/headerView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Wrong multi-line comment format.
```
reviewboard/static/rb/js/views/revisionSelectorView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Indented one level too far.
```
reviewboard/static/rb/js/views/revisionSelectorView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Array
```
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
This line's too long.
```
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Space after arg name.
```
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we spread this across lines?
```

reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

For readability, can we move the nameToRow[fieldName] bit out into something like elIndex? Took me a minute to figure out what this was doing.

Also, if we're indexing it this way, we're getting a DOM element, not a jQuery element.

reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing trailing comma.
```
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing trailing comma.
```
reviewboard/static/rb/js/views/uploadDiffView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Trailing comma?
```

Commit:

551650e6f496bfd577a93907a9ae6e8e7088ce29

6776492245f0e2eee7d39751571676ce99a1956a

Diff:

Revision 3 (+617 -510)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/floatingBannerView.js
	reviewboard/static/rb/js/views/headerView.js
	reviewboard/static/rb/js/views/revisionSelectorView.js
	reviewboard/static/rb/js/views/screenshotThumbnailView.js
	reviewboard/static/rb/js/views/starManagerView.js
	reviewboard/static/rb/js/views/updateDiffView.js
	reviewboard/static/rb/js/views/updateDiffView.es6.js
	3 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 27
 'errorListEl' is defined but never used.
```

Commit:

6776492245f0e2eee7d39751571676ce99a1956a

ee5c303d3d64e3a144955d86e0507208f30a9d81

Diff:

Revision 4 (+617 -510)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/floatingBannerView.js
	reviewboard/static/rb/js/views/headerView.js
	reviewboard/static/rb/js/views/revisionSelectorView.js
	reviewboard/static/rb/js/views/screenshotThumbnailView.js
	reviewboard/static/rb/js/views/starManagerView.js
	reviewboard/static/rb/js/views/updateDiffView.js
	reviewboard/static/rb/js/views/updateDiffView.es6.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/starManagerView.es6.js (Diff revision 4)

The issue has been dropped. Show all issues

I don't think we do this anywhere else for options. Instead, we list the individual options as optional if they are.

david Nov. 21, 2018, 4:42 p.m.

We do where there's actually a default value (options={}) and the entire parameter is optional.

Ship it!

reviewboard/static/rb/js/views/uploadDiffView.es6.js (Diff revision 4)

The issue has been resolved. Show all issues

There's no event parameter in this function.

reviewboard/static/rb/js/views/uploadDiffView.es6.js (Diff revision 4)

The issue has been resolved. Show all issues

Same here.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (119f102)