• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Convert a few more views to ES6.
    
 
    

    



 
    
 
    

  Review Request #10305
  —
  Created Nov. 2, 2018 and submitted 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-4.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  ee5c303...
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    This change migrates the remaining files in rb/js/views/ to ES6 syntax
    
and features.
    
 
    

    





  

    
 
 
    
  
    Ran js-tests.
    
 
    

    




 
    

    





    
 
    









 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    This line is too long.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Wrong multi-line comment format.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Indented one level too far.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Array
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    This line's too long.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Space after arg name.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Can we spread this across lines?
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    For readability, can we move the nameToRow[fieldName] bit out into something like elIndex? Took me a minute to figure out …
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Missing trailing comma.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Missing trailing comma.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Trailing comma?
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Col: 27 'errorListEl' is defined but never used.
    
          		
      
       reviewbotreviewbot
      
      
       
      
     
    



     
    
      
       
       
    I don't think we do this anywhere else for options. Instead, we list the individual options as optional if they …
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    There's no event parameter in this function.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    



     
    
      
       
       
    Same here.
    
          		
      
       chipx86chipx86
      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/headerView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      This line is too long.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/headerView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Wrong multi-line comment format.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 






    4. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/revisionSelectorView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Indented one level too far.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 






    5. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/revisionSelectorView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Array
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      6. 






    6. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      This line's too long.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      7. 






    7. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Space after arg name.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      8. 






    8. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Can we spread this across lines?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      9. 






    9. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      For readability, can we move the nameToRow[fieldName] bit out into something like elIndex? Took me a minute to figure out what this was doing.
      

      Also, if we're indexing it this way, we're getting a DOM element, not a jQuery element.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      10. 






    10. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Missing trailing comma.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      11. 






    11. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Missing trailing comma.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      12. 






    12. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadDiffView.es6.js
       


        (Diff revision 2)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Trailing comma?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      13. 




    13. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      14. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    









  
    
   
    
    Commit:
   
    
   
    
    
    551650e6f496bfd577a93907a9ae6e8e7088ce29
    6776492245f0e2eee7d39751571676ce99a1956a
    
   
    
  
    




  
    
   
    
    Diff:
   
    
   
    
    
     Revision 3 (+617 -510)
    Show changes
     
        reviewboard/staticbundles.py 
        reviewboard/static/rb/js/views/floatingBannerView.js 
        reviewboard/static/rb/js/views/headerView.js 
        reviewboard/static/rb/js/views/revisionSelectorView.js 
        reviewboard/static/rb/js/views/screenshotThumbnailView.js 
        reviewboard/static/rb/js/views/starManagerView.js 
        reviewboard/static/rb/js/views/updateDiffView.js 
        reviewboard/static/rb/js/views/updateDiffView.es6.js 
      3 more
     
    
   
    
  
    





    



    
 
    
  
    Checks run (1 failed, 1 succeeded)
    


  
    
 flake8
 passed.
 


    


  
    
 JSHint
 failed.
 


    


 
    








    
 
    JSHint
    
 
    

 

    





    




  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/starManagerView.es6.js
       


        (Diff revision 4)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      I don't think we do this anywhere else for options. Instead, we list the individual options as optional if they are.
      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
        We do where there's actually a default value (options={}) and the entire parameter is optional.
        
 
        

        2. 


 
      


      

 
      

      3. 




    3. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



chipx86




   
    
   
    







    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadDiffView.es6.js
       


        (Diff revision 4)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      There's no event parameter in this function.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/views/uploadDiffView.es6.js
       


        (Diff revision 4)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Same here.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 




    4. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-4.0.x (119f102)