flake8
passed.
JSHint
passed.
Convert a few more views to ES6.
Review Request #10305 — Created Nov. 2, 2018 and submitted
This change migrates the remaining files in rb/js/views/ to ES6 syntax
and features.
Ran js-tests.
| Description | From | Last Updated |
|---|---|---|
|
This line is too long. |
 chipx86
|
|
|
Wrong multi-line comment format. |
chipx86
|
|
|
Indented one level too far. |
chipx86
|
|
|
Array |
chipx86
|
|
|
This line's too long. |
chipx86
|
|
|
Space after arg name. |
chipx86
|
|
|
Can we spread this across lines? |
chipx86
|
|
|
For readability, can we move the nameToRow[fieldName] bit out into something like elIndex? Took me a minute to figure out … |
chipx86
|
|
|
Missing trailing comma. |
chipx86
|
|
|
Missing trailing comma. |
chipx86
|
|
|
Trailing comma? |
chipx86
|
|
|
Col: 27 'errorListEl' is defined but never used. |
 reviewbot
|
|
|
I don't think we do this anywhere else for options. Instead, we list the individual options as optional if they … |
chipx86
|
|
|
There's no event parameter in this function. |
chipx86
|
|
|
Same here. |
chipx86
|
Change Summary:
Fix some small regressions
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+598 -503) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
-
reviewboard/static/rb/js/views/revisionSelectorView.es6.js (Diff revision 2) Indented one level too far.
-
-
-
-
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2) Can we spread this across lines?
-
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2) For readability, can we move the
nameToRow[fieldName]bit out into something likeelIndex? Took me a minute to figure out what this was doing.Also, if we're indexing it this way, we're getting a DOM element, not a jQuery element.
-
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2) Missing trailing comma.
-
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 2) Missing trailing comma.
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+617 -510) |
Checks run (1 failed, 1 succeeded)
flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js (Diff revision 3) Col: 27 'errorListEl' is defined but never used.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+617 -510) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/views/starManagerView.es6.js (Diff revision 4) I don't think we do this anywhere else for
options. Instead, we list the individual options asoptionalif they are.
-
-
reviewboard/static/rb/js/views/uploadDiffView.es6.js (Diff revision 4) There's no
eventparameter in this function. -