-
-
-
reviewboard/htdocs/media/rb/css/admin.css (Diff revision 1) We should make sure that -6px is correct for this case. If you increase your text zoom a lot, does it look okay? We may want to use em.
-
Improved usability by adding a tabbish feel to admin navbar.
Review Request #1029 — Created Sept. 8, 2009 and submitted
When configuring ReviewBoard is really easy to loose track on which tab you are, since there was no visual cue to that. There was a css class already in admin.css called '#admin-subnav li a.active', but it was never used. So I hooked it up in the code, so it stared being used. But then it clashed too much, and the tabs didn't feel like tabs. So I changed it to include a background and a border so users can instantly recognize where they are. Since the breadcrumbs part has a little gradient, I had to expand that gradient otherwise the background clashed.
Tested result in Safari 4.0, Firefox 3.5 and 3.0 and Chromium Nightly.
Screenshots
Change Summary:
Updated the diff to include the template tag suggestion by Christian and fixed space issues in CSS.
Diff: |
Revision 2 (+45 -10) |
---|
Change Summary:
Some things slipped by the last diff, so further cleaning was necessary.
Diff: |
Revision 3 (+44 -9) |
---|
-
-
-
reviewboard/admin/templatetags/admintags.py (Diff revision 3) Actually, it might be better to render using a template which would have this logic. While technically slower, it keeps presentation in the templates. You can do this with an inclusion tag, which the docs should cover.
-
-
-
reviewboard/templates/admin/settings.html (Diff revision 3) Hmm, maybe we should call these rbadmintags, so that there's no possible conflict with Django's own admin stuff.
-
reviewboard/templates/admin/settings.html (Diff revision 3) You should use _("General"), etc. so that it's internationalized. You'll need to {% load i18n %} for this, I think.
-
Hi Eduardo. Just a few small stylistic things and then it's ready to commit :) We need to set you up on GitHub with commit access, so let us know what your GitHub username is (if you have one) and we'll set it up.
-
reviewboard/admin/templatetags/rbadmintags.py (Diff revision 4) This would be better formatted as: return { 'url': url, 'name': name, 'current': url == request.path, }
-
reviewboard/admin/urls.py (Diff revision 4) Make sure the {...} aligns with the r'...'. Also, name="logging" would be better on its own line, aligned with r'..' and {..}
-
-
reviewboard/templates/admin/subnav_item.html (Diff revision 4) Variables (as opposed to template tags) should be in the form of {{url}}.
Change Summary:
Made all the changes requested by Christian. FYI I'm edufelipe on github.
Diff: |
Revision 5 (+53 -17) |
---|
-
-
reviewboard/admin/urls.py (Diff revision 5) Really sorry, but I didn't think of this before. Can you change the names to settings-general, settings-email, etc? Less chance of collisions with other things. Make sure to update the template as well. Then it's ready to commit! :) You'll need to edit your .git/config and change origin's url to git@github.com:reviewboard/reviewboard.git. Then squash this into one commit in master preferably so it doesn't appear as a merge, add the "Reviewed at http://reviews.review-board.org/r/1029/" and then `git push origin master`.