Summary

Add DVCS support for rbt patch

Review Request #10286 — Created Oct. 26, 2018 and submitted Nov. 13, 2018, 4:58 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

3dc4768...

Reviewers

Groups

rbtools

People

Description

rbt patch can now apply the patches from specific commits from a
review request created with commit history support. As part of this
change, the Patch.get_patch method has been deprecated in favour of
the new Patch.get_patch_data method, which returns a dictionary
instead of a tuple, which is more extendable for the future.

Testing Done


Applied patches from a review request created with commit history.
Attempted to patch a review request created with commit history

  without a commit ID and got the expected error.
Applied a patch from a review request created without commit

  history.

Issues

Description	From	Last Updated
F841 local variable 'tool' is assigned to but never used	reviewbot	Oct. 26, 2018, 12:32 p.m.
I know others here are bad but this docstring isn't in our modern format.	david	Nov. 11, 2018, 10:01 a.m.
Needs a docstring.	david	Nov. 11, 2018, 10:04 a.m.
Is there anything in here that uses this? Code in commands/ isn't really intended to be "library" code and we …	david	Nov. 11, 2018, 10:09 a.m.
This case is impossible to reach.	david	Nov. 11, 2018, 10:10 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/patch.py (Diff revision 1)

Show all issues

F841 local variable 'tool' is assigned to but never used

Change Summary:

Post entire change

Commit:

-	55f22bd6410df74bad502a28f7b94e59c50be68a
+	2d4599e3ccbc47045fbbbc20f51707a567471452

Diff:

Revision 2 (+255 -41)

Show changes

	rbtools/api/resource.py
	rbtools/commands/patch.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

oopsie

Testing Done:

~		Applied patches from a review request created with history.
~		Attempted to patch a review request created with history without a commit ID and got the expected error.
	~	Applied patches from a review request created with commit history.
	~	Attempted to patch a review request created with commit history without a commit ID and got the expected error.
	+	Applied a patch from a review request created without commit history.

Commit:

-	2d4599e3ccbc47045fbbbc20f51707a567471452
+	59dd8fa95f5bc3a203a6afc87949a815ff62c0d3

Diff:

Revision 3 (+255 -41)

Show changes

	rbtools/api/resource.py
	rbtools/commands/patch.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/resource.py (Diff revision 3)

Show all issues

I know others here are bad but this docstring isn't in our modern format.

rbtools/commands/patch.py (Diff revision 3)
Show all issues
```
Needs a docstring.
```

rbtools/commands/patch.py (Diff revision 3)

Show all issues

Is there anything in here that uses this? Code in commands/ isn't really intended to be "library" code and we probably don't need to formally deprecate and leave things around the way we might in other parts of rbtools.

rbtools/commands/patch.py (Diff revision 3)
Show all issues
```
This case is impossible to reach.
```

Commit:

-	59dd8fa95f5bc3a203a6afc87949a815ff62c0d3
+	3dc47683e9d52ce0732de3b169c60eb3c41643e0

Diff:

Revision 4 (+212 -41)

Show changes

	rbtools/api/resource.py
	rbtools/commands/patch.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (87e5d38)