Add DVCS support for rbt patch

Review Request #10286 — Created Oct. 26, 2018 and submitted

brennie
RBTools
master
3dc4768...
rbtools

rbt patch can now apply the patches from specific commits from a
review request created with commit history support. As part of this
change, the Patch.get_patch method has been deprecated in favour of
the new Patch.get_patch_data method, which returns a dictionary
instead of a tuple, which is more extendable for the future.

  • Applied patches from a review request created with commit history.
  • Attempted to patch a review request created with commit history
    without a commit ID and got the expected error.
  • Applied a patch from a review request created without commit
    history.
Description From Last Updated

F841 local variable 'tool' is assigned to but never used

reviewbotreviewbot

I know others here are bad but this docstring isn't in our modern format.

daviddavid

Needs a docstring.

daviddavid

Is there anything in here that uses this? Code in commands/ isn't really intended to be "library" code and we ...

daviddavid

This case is impossible to reach.

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
brennie
david
  1. 
      
  2. rbtools/api/resource.py (Diff revision 3)
     
     

    I know others here are bad but this docstring isn't in our modern format.

  3. rbtools/commands/patch.py (Diff revision 3)
     
     

    Needs a docstring.

  4. rbtools/commands/patch.py (Diff revision 3)
     
     

    Is there anything in here that uses this? Code in commands/ isn't really intended to be "library" code and we probably don't need to formally deprecate and leave things around the way we might in other parts of rbtools.

  5. rbtools/commands/patch.py (Diff revision 3)
     
     

    This case is impossible to reach.

  6. 
      
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (87e5d38)
Loading...