flake8
-
rbtools/commands/patch.py (Diff revision 1) Show all issues
Review Request #10286 — Created Oct. 26, 2018 and submitted
rbt patch
can now apply the patches from specific commits from a
review request created with commit history support. As part of this
change, thePatch.get_patch
method has been deprecated in favour of
the newPatch.get_patch_data
method, which returns a dictionary
instead of a tuple, which is more extendable for the future.
Description | From | Last Updated |
---|---|---|
F841 local variable 'tool' is assigned to but never used |
![]() |
|
I know others here are bad but this docstring isn't in our modern format. |
|
|
Needs a docstring. |
|
|
Is there anything in here that uses this? Code in commands/ isn't really intended to be "library" code and we … |
|
|
This case is impossible to reach. |
|
Post entire change
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+255 -41) |
oopsie
Testing Done: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||
Diff: |
Revision 3 (+255 -41) |
rbtools/api/resource.py (Diff revision 3) |
---|
I know others here are bad but this docstring isn't in our modern format.
rbtools/commands/patch.py (Diff revision 3) |
---|
Is there anything in here that uses this? Code in commands/ isn't really intended to be "library" code and we probably don't need to formally deprecate and leave things around the way we might in other parts of rbtools.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+212 -41) |