flake8
passed.
JSHint
passed.
Properly render review request details page when draft has no commits
Review Request #10284 — Created Oct. 26, 2018 and submitted
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-4.0.x | |
| 65d7a26... | |
| Reviewers | |
| reviewboard | |
When a draft review request was added without an associated diff, we
would fail to render the reviewable page model data due to assuming that
the review request details (which might be a draft or a review request)
would walways have a diffset attached. This assumption has been
corrected.
Am now able to view a review request details page for a review request
created without commit history support when the current draft does not
have a diff attached.When there is a draft with a diffset attached, the draft commits are
shown instead.
| Description | From | Last Updated |
|---|---|---|
|
Won't this make it so you see the old commits even when there's a new history in the draft? |
 david
|
Change Summary:
Addressed feedback
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+4) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.