Summary

Add compatibility with relation field attribute changes in Django 1.9+.

Review Request #10266 — Created Oct. 23, 2018 and submitted Oct. 24, 2018, 2:35 a.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

3f0ab0b...

Reviewers

Groups

django-evolution

People

Description

Django 1.9 replaced Field.rel with Field.remote_field, along with a
handful of other attributes, as part of an effort to provide a
supported, documented API for field relations.

This change adds compatibility with both the old undocumented API and
the new documented API through the addition of get_remote_field() and
get_remote_field_model() functions. These are used instead of
.rel/.rel.to and .remote_field/.remote_field.model accessors.

Testing Done

Unit tests pass on Django 1.6 through 1.11, and 2.1 with additional
changes.

Issues

Description	From	Last Updated
F401 'django_evolution.compat.models.get_remote_field_model' imported but unused	reviewbot	Oct. 23, 2018, 7:41 p.m.
F401 'django_evolution.compat.models.get_remote_field' imported but unused	reviewbot	Oct. 23, 2018, 7:41 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/db/sqlite3.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django_evolution.compat.models.get_remote_field_model' imported but unused
```
django_evolution/db/sqlite3.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django_evolution.compat.models.get_remote_field' imported but unused
```

Change Summary:

Removed unused imports.

Commit:

-	f69d5b6a4da26af5b8f357248ed40f914249b735
+	3f0ab0b73b57f32ed1506bff73c2c9cf15eb26fa

Diff:

Revision 2 (+171 -64)

Show changes

	django_evolution/mock_models.py
	django_evolution/signature.py
	django_evolution/compat/db.py
	django_evolution/compat/models.py
	django_evolution/db/common.py
	django_evolution/db/mysql.py
	django_evolution/tests/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (c6b16c9)