Summary

Add new Django and Python compatibility functions.

Review Request #10251 — Created Oct. 21, 2018 and submitted Oct. 24, 2018, 2:17 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Commit

570294a...

Reviewers

Groups

djblets

People

Description

The new djblets.util.compat.django.shortcuts module features a
version of render() that works with older and newer versions of
Django. Any existing calls to render() or render_to_response()
should be updated to use this.

The new djblets.util.compat.django.utils.functional provides a
backport of SimpleLazyObject, which supports more special functions
like __iter__, __contains__, and more. This is a drop-in replacement
for Django's SimpleLazyObject.

The new djblets.util.compat.python.past is intended to provide
re-implementations of old useful capabilities that have been removed
from Python 3.x. For now, it provides cmp, which Python 3 has removed
in favor of a hard-to-remember comparison expression. For readability,
consistency, and easier development, our version can be used in place of
that expression.

Testing Done

Made use of this in some pending code. These worked on Python 2.7,
3.5, and 3.6.

Issues

Description	From	Last Updated
typo: .oy -> .py	david	Oct. 22, 2018, 10:08 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E501 line too long (96 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E501 line too long (80 > 79 characters)	reviewbot	Oct. 21, 2018, 2:06 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E303 too many blank lines (2)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 21, 2018, 2:05 a.m.
E731 do not assign a lambda expression, use a def	reviewbot	Oct. 21, 2018, 2:05 a.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (96 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E303 too many blank lines (2)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E303 too many blank lines (2)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Oct. 22, 2018, 10:11 p.m.
E731 do not assign a lambda expression, use a def	reviewbot	Oct. 22, 2018, 10:11 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (96 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/python/past.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E731 do not assign a lambda expression, use a def
```

djblets/util/compat/django/utils/functional.py (Diff revision 1)
The issue has been resolved. Show all issues
```
typo: .oy -> .py
```

Change Summary:

Fixed a typo in a referenced filename in a comment.

Commit:

-	a1c67e2713e8e69dd995fa90d8a566c11f6b9605
+	570294a3077f8569c15afaab99189cef3528ad5d

Diff:

Revision 2 (+312)

Show changes

	djblets/util/compat/django/shortcuts.py
	djblets/util/compat/django/utils/__init__.py
	djblets/util/compat/django/utils/functional.py
	djblets/util/compat/python/__init__.py
	djblets/util/compat/python/past.py
	docs/djblets/coderef/index.rst

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (96 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (81 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/functional.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/python/past.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E731 do not assign a lambda expression, use a def
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (4e3119f)