Send base FileDiff ID when commenting on commit ranges
Review Request #10242 — Created Oct. 19, 2018 and submitted — Latest diff uploaded
We now include base FileDiff ID (where appropriate) when commenting on
commit ranges. This allows us to create comments on FileDiffs with a
base FileDiff.
- Commented on a FileDiff with a base FileDiff and saw the correct
result in the database. - Refreshed the diffviewer and saw that comment flag render
correctly.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
| reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js |
|---|
| reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js |
|---|
| reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/diffCommentModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/reviewModel.es6.js |
|---|