flake8
passed.
JSHint
passed.
Send base FileDiff ID when commenting on commit ranges
Review Request #10242 — Created Oct. 19, 2018 and submitted
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-4.0.x | |
|
|
|
| c02bedd... | |
| Reviewers | |
| reviewboard | |
We now include base FileDiff ID (where appropriate) when commenting on
commit ranges. This allows us to create comments on FileDiffs with a
base FileDiff.
- Commented on a FileDiff with a base FileDiff and saw the correct
result in the database. - Refreshed the diffviewer and saw that comment flag render
correctly.
Change Summary:
Allow commenting on cumulative diffs.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+94 -24) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Do not expect base_filediff in response
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+83 -24) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.