Summary

Send base FileDiff ID when commenting on commit ranges

Review Request #10242 — Created Oct. 19, 2018 and submitted Oct. 25, 2018, 10:28 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~10190~~

Commit

c02bedd...

Reviewers

Groups

reviewboard

People

Description

We now include base FileDiff ID (where appropriate) when commenting on
commit ranges. This allows us to create comments on FileDiffs with a
base FileDiff.

Testing Done


Commented on a FileDiff with a base FileDiff and saw the correct

  result in the database.
Refreshed the diffviewer and saw that comment flag render

  correctly.

flake8 passed.

JSHint passed.

```
Ship It!
```

Change Summary:

Allow commenting on cumulative diffs.

Commit:

d580ee20eed0a1a9756d1be40950df9f3ca9d7c0

283a325a36b3af45c7b37c7d3093564b87e23ea2

Diff:

Revision 2 (+94 -24)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
	reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js
	reviewboard/static/rb/js/resources/models/diffCommentModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Do not expect base_filediff in response

Commit:

283a325a36b3af45c7b37c7d3093564b87e23ea2

c02bedd5dcdf1179b58ce74dfd4d3051ea4a1ce4

Diff:

Revision 3 (+83 -24)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
	reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js
	reviewboard/static/rb/js/resources/models/diffCommentModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (16c952e)