Summary

Serialize source/dest file information in validation_info

Review Request #10234 — Created Oct. 16, 2018 and discarded Oct. 17, 2018, 3:47 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The validation_info payloads now contain source and/or destination
information (depending on the operation, e.g., removals don't have
destinations since the file no longer exists).

This will allow us to compare the validation info to a cumulative diff.

Testing Done

Ran unit tests.

flake8 passed.

JSHint passed.

Testing Done:

Ran unit tests.

Change Summary:

Added more unit tests.

Commit:

-	d6376fba9469a26781dbe25323ef7307b8c599d5
+	2701bffc75ffd28bdb2d1d7c2937baf67cde3c8e

Diff:

Revision 2 (+308 -51)

Show changes

	reviewboard/diffviewer/commit_utils.py
	reviewboard/diffviewer/tests/test_commit_utils.py
	reviewboard/diffviewer/tests/test_forms.py
	reviewboard/webapi/tests/test_draft_diffcommit.py
	reviewboard/webapi/tests/test_validate_diffcommit.py

Checks run (2 succeeded)