• 
      

    Move commit validation utilities into commit_utils

    Review Request #10227 — Created Oct. 12, 2018 and submitted

    Information

    Review Board
    release-4.0.x
    02ae1b0...

    Reviewers

    The utilities for serialization, deserialization, and generation of
    commit validation metadata have been moved into the commit_utils
    module. Previously, the (de-)serialization logic was implemented in a
    multitude of places and the generation was intrinsically tied to the
    ValidateDiffCommitResource.

    However, we will soon require validation metadata in the
    DraftDiffResource for finalization of commit series, and so to not
    reimplement this all in another place, it has been refactored into the
    diffviewer.commit_utils module.

    Ran unit tests.

    Description From Last Updated

    F401 'reviewboard.diffviewer.commit_utils.deserialize_validation_info' imported but unused

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    brennie
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (b6c2dce)