[WIP] Review Composer: Sidebar

Review Request #10225 — Created Oct. 12, 2018 and updated

bolariinwa
Review Board
master
973493d...
reviewboard, students

Working on the sidebar for the review composer. It is expected to have a new button
to create general comment. A rendered list of comments with a bit of summary and a
tips section.

I am currently learning about views so that I can make reuse the code in the
reviewDialogView.es6.js. I have started on the review composer sidebar view, I am
currently trying to make sense of the functions in the file to see how I can use them.



Loading file attachments...

  • 0
  • 0
  • 11
  • 0
  • 11
Description From Last Updated
bolariinwa
bolariinwa
bolariinwa
bolariinwa
brennie
  1. 
      
  2. Since we're doing _super.remove below we don't need this.

  3. Doing render() here will break things.

  4. This should be this.$el.append($generalCommentButton).

  5. 
      
bolariinwa
bolariinwa
bolariinwa
bolariinwa
bolariinwa
Review request changed

Commit:

-41a14e598e91c79ec3df033cec9e10579d6492cd
+a0cf5d26ce9ff762da87090594209b980d7b7b3f

Diff:

Revision 9 (+88 -15)

Show changes

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

bolariinwa
bolariinwa
bolariinwa
brennie
  1. 
      
  2. You don't need this becuase of the _super call below.

  3. This should be in its own file. You will have to add the new file to staticbundles.py.

  4. 
      
bolariinwa
bolariinwa
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

bolariinwa
bolariinwa
Review request changed

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...