Since we're doing _super.remove below we don't need this.

Doing render() here will break things.

This should be this.$el.append($generalCommentButton).

Col: 15 'commentList' is defined but never used.

Col: 15 'tipsSection' is defined but never used.

Col: 69 Missing semicolon.

You don't need this becuase of the _super call below.

This should be in its own file. You will have to add the new file to staticbundles.py.

Col: 29 Missing semicolon.

Col: 63 Missing semicolon.

Col: 11 Missing semicolon.

Col: 35 Missing semicolon.

Alphabetize.

Alphabetize.

Alphabetize.

space between selector and {

These are not very semantic styles. Their names indicate what they do, not why they do it or what they …

Space between selector and {

This should return this.

Col: 7 'DiffCommentView' is defined but never used.

Same comment here re: inline styles.

Col: 7 'FileAttachmentCommentView' is defined but never used.

Col: 7 'GeneralCommentView' is defined but never used.

Col: 7 'ScreenshotCommentView' is defined but never used.

We try to avoid inline style as much as possible. Is there a reason this can't be added to a …

Col: 7 'HeaderFooterCommentView' is defined but never used.

If it is intentionally a no-op, you do not need to define it since the parent already does. Same elsewhere.

Col: 7 'ReviewOutline' is defined but never used.

Col: 3 Missing semicolon.

Same comment here re: inline styles.

Our templates are indented a single space, not four.

Space after ). Same elsewhere

This is also using inline style.

How about: this.listenTo( reviewDialogView._fileAttachmentCommentsCollection, 'add', comment => this._renderComment($reviewOutline, comment));

Since you're not doing anything with tipsSection, you can just do: this.$('#sidebar-tips-section') .append($(this.tipsTemplate({ ... })));

As a convention, we name jQuery objects $foo.

This should have $() wrapped around the template to convert create the DOM nodes to attach to the tree.

Since you aren't doing anything with $buttons afterwards, you can just do: this.$('#sidebar-tips-button') .append(...);

Our templates are indented a single space, not four.

Col: 7 'DiffCommentView' is defined but never used.

Col: 7 'FileAttachmentCommentView' is defined but never used.

Col: 7 'GeneralCommentView' is defined but never used.

Col: 7 'ScreenshotCommentView' is defined but never used.

Col: 7 'HeaderFooterCommentView' is defined but never used.

Col: 7 'ReviewOutline' is defined but never used.

Col: 3 Missing semicolon.

Col: 7 'HeaderFooterCommentView' is defined but never used.

Col: 58 Missing semicolon.

Col: 58 Missing semicolon.

Col: 58 Missing semicolon.

Col: 58 Missing semicolon.

Col: 7 'HeaderFooterCommentView' is defined but never used.

Space after selector and before opening brace.

Is text HTML-escaped? Or do we know its safe HTML? If not we need to use <%- text %>.

<%- text %>

Same comment about <%= foo %> vs <%- foo %>.

<br> and it should be on the next line.

<%- lines %>

Unnecessary -- this is the default impl.

Here too

Space between ) and {

Should be indented one space.

<%- text %>

<br> on next line.

Unnecessary.

Same comment here vs <%= vs <%-.

<%- text %>

<br> on next line.

Unnecessary.

This has to be marked for translation with gettext(). Replace this with a template var and pass in the result …

This has to be marked for translation with gettext(). Replace this with a template var and pass in the result …

Same comment here about <%= vs <%-.

We should avoid <b> in favour of <strong>, which is more semantic (see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strong) However, since this is a title, …

I don't know that we need an id selector here. class="tip-text" would be fine.

gettext()

Single quotes for strings

Text needs to be marked for translation with gettext, e.g. $('<span class="fa fa-plus"></span>') .text(gettext('Add a general comment'))

If you are going to use this for a multi-line string, use dedent, e.g. $(dedent` <span class="left-button fa fa-caret-left"></span> <span …

Undo

Comments should end in a period. However, I think the behaviour can be inferred from the name.

Comments should end in a period. Again, I don't know that this is necessary.

This file needs to be wrapped in an IIFE to not pollute global scope, e.g. (function() { const BaseCommentView = …

Undo

.sidebar-tips-button before .sidebar-tips-section.

No blank line here.

No blank line here.

Move this to right before the block it is defined in.

No blank line here.

This does not interpolate variables, so it can just be a string literal.

Instead of passing tips and current into the template, you can pass tip as tips[current] and use that instead.

There is an extra ", right before class

Needs a docstring.

Col: 22 Missing semicolon.

Col: 5 'emptyDiffCommentsPayload' is defined but never used.

Col: 5 'emptyFileAttachmentCommentsPayload' is defined but never used.

Col: 5 'emptyGeneralCommentsPayload' is defined but never used.

Col: 5 'emptyScreenshotCommentsPayload' is defined but never used.

Col: 5 'diffCommentPayload' is defined but never used.

Col: 5 'fileAttachmentCommentPayload' is defined but never used.

Col: 5 'generalCommentPayload' is defined but never used.

Col: 5 'screenshotCommentPayload' is defined but never used.

Col: 5 'origGeneralCommentsEnabled' is defined but never used.

Col: 5 'dlg' is defined but never used.

Col: 10 'createReviewDialog' is defined but never used.

Col: 21 'ajaxData' is defined but never used.

Col: 96 Missing semicolon.

Col: 70 Missing semicolon.

Col: 41 Expected '===' and instead saw '=='.

Col: 56 Missing semicolon.

Col: 70 Missing semicolon.

W503 line break before binary operator

W503 line break before binary operator

W503 line break before binary operator