Remove DiffCommit.file_count and DiffSet.file_count fields
Review Request #10216 — Created Oct. 11, 2018 and submitted — Latest diff uploaded
This patch removes the above mentioned fields because we will now be
tracking per-commit FileDiffs and cumulative (i.e., a cumulative diff of
the entire commit series) FileDiffs in theDiffSet.filesfield, and
thefile_countfield will no longer be of any use in that case.Since the mixin defining the
file_countwould only now be providing a
utility method, the mixin has been removed and the method has been moved
into a free function which bothDiffCommit.get_total_line_countsand
DiffSet.get_total_line_countscall into.
Ran unit tests.