• 
      

    Remove DiffCommit.file_count and DiffSet.file_count fields

    Review Request #10216 — Created Oct. 11, 2018 and submitted

    Information

    Review Board
    release-4.0.x
    a9ef2fc...

    Reviewers

    This patch removes the above mentioned fields because we will now be
    tracking per-commit FileDiffs and cumulative (i.e., a cumulative diff of
    the entire commit series) FileDiffs in the DiffSet.files field, and
    the file_count field will no longer be of any use in that case.

    Since the mixin defining the file_count would only now be providing a
    utility method, the mixin has been removed and the method has been moved
    into a free function which both DiffCommit.get_total_line_counts and
    DiffSet.get_total_line_counts call into.

    Ran unit tests.

    Description From Last Updated

    Can't we return counts directly?

    chipx86chipx86
    chipx86
    1. 
        
    2. reviewboard/diffviewer/diffutils.py (Diff revision 1)
       
       
      Show all issues

      Can't we return counts directly?

    3. 
        
    brennie
    brennie
    brennie
    chipx86
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (5a726c5)