Remove DiffCommit.file_count and DiffSet.file_count fields
Review Request #10216 — Created Oct. 11, 2018 and submitted
This patch removes the above mentioned fields because we will now be
tracking per-commit FileDiffs and cumulative (i.e., a cumulative diff of
the entire commit series) FileDiffs in theDiffSet.files
field, and
thefile_count
field will no longer be of any use in that case.Since the mixin defining the
file_count
would only now be providing a
utility method, the mixin has been removed and the method has been moved
into a free function which bothDiffCommit.get_total_line_counts
and
DiffSet.get_total_line_counts
call into.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Can't we return counts directly? |
|
Change Summary:
Addressed feedback
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+112 -85) |
Checks run (2 succeeded)
Description: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 3 (+114 -87) |
Checks run (2 succeeded)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+116 -89) |