Remove DiffCommit.file_count and DiffSet.file_count fields
Review Request #10216 — Created Oct. 11, 2018 and submitted
This patch removes the above mentioned fields because we will now be
tracking per-commit FileDiffs and cumulative (i.e., a cumulative diff of
the entire commit series) FileDiffs in theDiffSet.files
field, and
thefile_count
field will no longer be of any use in that case.Since the mixin defining the
file_count
would only now be providing a
utility method, the mixin has been removed and the method has been moved
into a free function which bothDiffCommit.get_total_line_counts
and
DiffSet.get_total_line_counts
call into.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Can't we return counts directly? |
chipx86 |
- Change Summary:
-
Addressed feedback
- Commit:
-
7c24c9992050a43a8e2641eb48493eaae96f0c776888c6980195e8ad92ea7d2c79d03baa1d1d58e4
- Diff:
-
Revision 2 (+112 -85)
Checks run (2 succeeded)
- Description:
-
This patch removes the above mentioned fields because we will now be
tracking per-commit FileDiffs and cumulative (i.e., a cumulative diff of the entire commit series) FileDiffs in the DiffSet.files
field, andthe file_count
field will no longer be of any use in that case.+ + Since the mixin defining the
file_count
would only now be providing a+ utility method, the mixin has been removed and the method has been moved + into a free function which both DiffCommit.get_total_line_counts
and+ DiffSet.get_total_line_counts
call into. - Commit:
-
6888c6980195e8ad92ea7d2c79d03baa1d1d58e49beb550e34540655eeb7fb480ffeb0b670f23c1e
- Diff:
-
Revision 3 (+114 -87)
Checks run (2 succeeded)
- Commit:
-
9beb550e34540655eeb7fb480ffeb0b670f23c1ea9ef2fca9da2bf7ad85a145082645a452efa26bc
- Diff:
-
Revision 4 (+116 -89)