Replace old selectors with smart objects selector widget in the administration UI
Review Request #10215 — Created Oct. 10, 2018 and submitted — Latest diff uploaded
Now that
RelatedObjectedWidgetis in Djblets, we import
it from there and extend it in theRelatedUserWidget.Created
RelatedRepositoryWidgetandRelatedGroupWidget, along with
relevant HTML and JS files, which extends theRelatedObjectsWidget.
RelatedGroupWidgethas the ability to only display groups that are
invite only. All three widgets, for exampe, can be viewed on
/admin/db/reviews/defaultreviewer/add/, and they all function.See /r/10214.
Created
relatedUserSelectorTests.es6.js,
relatedRepoSelectorTests.es6.js, and
relatedGroupSelectorTests.es6.jsto test the widgets
javascript functionality.Ran
./tests/runtests.pyand no errors were thrown. Ran the js-tests, and
no errors were thrown.New unit tests were created in
reviewboard.admin.teststhat test
the functionality of the widgets. The test classes are:
RelatedUserWidgetTestCase,RelatedRepositoryWidgetTestCaseand,
RelatedGroupWidgetTestCase.Navigated to
/admin/db/reviews/defaultreviewer/add/and the
RelatedUserWidget,RelatedRepositoryWidgetand
RelatedGroupWidgetfunction as intended.
| reviewboard/static/rb/js/admin/views/relatedRepoSelectorView.es6.js |
|---|