Replace old selectors with smart objects selector widget in the administration UI

 






 

 


  Review Request #10215
  —
  Created Oct. 10, 2018 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  skaefer143
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10214
 









 
 

  11714f4...
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
Now that RelatedObjectedWidget is in Djblets, we import

it from there and extend it in the RelatedUserWidget.


Created RelatedRepositoryWidget and RelatedGroupWidget, along with

relevant HTML and JS files, which extends the RelatedObjectsWidget.

RelatedGroupWidget has the ability to only display groups that are

invite only. All three widgets, for exampe, can be viewed on

/admin/db/reviews/defaultreviewer/add/, and they all function.


See /r/10214.

 








  


 
 

  
Created relatedUserSelectorTests.es6.js, 

relatedRepoSelectorTests.es6.js, and 

relatedGroupSelectorTests.es6.js to test the widgets 

javascript functionality.


Ran ./tests/runtests.py and no errors were thrown. Ran the js-tests, and

no errors were thrown.


New unit tests were created in reviewboard.admin.tests that test

the functionality of the widgets. The test classes are:

RelatedUserWidgetTestCase, RelatedRepositoryWidgetTestCase and,

RelatedGroupWidgetTestCase.


Navigated to /admin/db/reviews/defaultreviewer/add/ and the 

RelatedUserWidget, RelatedRepositoryWidget and 

RelatedGroupWidget function as intended.

 







 









 





  








 




 







   

    
    
Diff Revision 20


This is not the most recent revision of the diff. The latest diff is revision 26. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26

 



    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/form_widgets.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/tests.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/notifications/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/notifications/tests/test_admin.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/oauth/tests.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_admin.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/ui/related-object-selector.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/views/relatedGroupSelectorView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/views/relatedObjectSelectorView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/views/relatedRepoSelectorView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/accounts/edit_oauth_app.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/admin/base_site.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/admin/related_group_widget.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/admin/related_repo_widget.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/admin/related_user_widget.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/admin/oauth/application/change_form.html
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/js/tests_base.html
     
    

   
  

 










     

    

   

  

  

   
   Loading...