Summary:

Switch from smart_unicode/force_unicode to force_text.

Review Request #10206 — Created Oct. 8, 2018 and submitted Oct. 13, 2018, 2:06 a.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:	release-4.0.x
Bugs:
Depends On:
Commit:	16c12b6...
Reviewers
Groups:	reviewboard
People:

Description

Django's smart_unicode and force_unicode functions were deprecated
long ago in favor of smart_text and force_text. We use both in a few
places, though for smart_unicode we really wanted the force_
versions.

This change updates the code to call these modern methods instead,
getting us a small step toward modern Django compatibility.

Testing Done

Unit tests pass.

flake8 passed.

JSHint passed.

Summary:

-	Switch from smart_unicode to force_text.
+	Switch from smart_unicode/force_unicode to force_text.

Ship it!

```
Ship It!
```

Change Summary:

Addressed feedback.

Branch:

-	release-4.0.x
+	release-3.0.x

Commit:

-	7b53d3ea5e55cc16840dbc2aa0b8f6fe09987af3
+	0c3b031e6bf22d35b4b0a983c6bbe1c07c7a3956

Diff:

Revision 2 (+93 -6)

Show changes

reviewboard/diffviewer/tests/test_diffutils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Bringing back my change that was overwritten.

Branch:

-	release-3.0.x
+	release-4.0.x

Commit:

-	0c3b031e6bf22d35b4b0a983c6bbe1c07c7a3956
+	16c12b665f9527e8a9aa159b782ce36722d57c05

Diff:

Revision 3 (+8 -8)

Show changes

	reviewboard/attachments/mimetypes.py
	reviewboard/diffviewer/filediff_creator.py
	reviewboard/diffviewer/forms.py
	reviewboard/webapi/base.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (d23d898)