Summary

Remove types.NoneType usage from the codebase.

Review Request #10200 — Created Oct. 7, 2018 and submitted Oct. 9, 2018, 12:40 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

78549ac...

Reviewers

Groups

reviewboard

People

Description

The WebHook code was checking values against types.NoneType, which
exists on Python 2 but not 3. To fix compatibility there, we now just
check if the values are None rather than checking for NoneType.

Testing Done

Unit tests pass.

Imports succeed on Python 3.

flake8 passed.

JSHint passed.

Expand All
Collapse All

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (b904a29)