Update RB.DiffReviewableView to modern standards

Review Request #10194 — Created Oct. 4, 2018 and submitted

Information

Review Board
release-4.0.x
0d3a1df...

Reviewers

This patch updates RB.DiffReviewableView and its unit tests to use
ES6 features and our documentation standards. Although the
RB.DiffReviewableView was written in an ES6 file, it was still using
var everywhere over let and const. It was also wrapped in a
superfluous IIFE.

Ran JS tests.

Description From Last Updated

Typo in description: Althought

daviddavid

Indentation is funky here.

daviddavid

This could be: $children.first().toggleClass('first'); $children.last().toggleClass('last');

daviddavid

Extra blank line.

chipx86chipx86

Can we keep one param per line here? Just nicer to read it that way.

chipx86chipx86

Missing docs.

chipx86chipx86

Missing Args.

chipx86chipx86

"Handle"

chipx86chipx86

This does not English good.

chipx86chipx86

Missing a blank line here.

chipx86chipx86
david
  1. 
      
  2. Typo in description: Althought

  3. Indentation is funky here.

  4. This could be:

    $children.first().toggleClass('first');
    $children.last().toggleClass('last');
    
  5. 
      
brennie
chipx86
  1. 
      
  2. Can we keep one param per line here? Just nicer to read it that way.

  3. Missing Args.

  4. This does not English good.

  5. 
      
brennie
chipx86
  1. 
      
  2. Missing a blank line here.

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (af514f1)
Loading...