Update RB.DiffReviewableView to modern standards
Review Request #10194 — Created Oct. 4, 2018 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-4.0.x | |
0d3a1df... | |
Reviewers | |
reviewboard | |
This patch updates
RB.DiffReviewableView
and its unit tests to use
ES6 features and our documentation standards. Although the
RB.DiffReviewableView
was written in an ES6 file, it was still using
var
everywhere overlet
andconst
. It was also wrapped in a
superfluous IIFE.
Ran JS tests.
Description | From | Last Updated |
---|---|---|
Typo in description: Althought |
|
|
Indentation is funky here. |
|
|
This could be: $children.first().toggleClass('first'); $children.last().toggleClass('last'); |
|
|
Extra blank line. |
|
|
Can we keep one param per line here? Just nicer to read it that way. |
|
|
Missing docs. |
|
|
Missing Args. |
|
|
"Handle" |
|
|
This does not English good. |
|
|
Missing a blank line here. |
|
-
-
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js (Diff revision 1) Indentation is funky here.
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js (Diff revision 1) This could be:
$children.first().toggleClass('first'); $children.last().toggleClass('last');
Change Summary:
Addressed feedback.
Description: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||
Diff: |
Revision 2 (+322 -288) |
Checks run (2 succeeded)
-
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js (Diff revision 2) Extra blank line.
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js (Diff revision 2) Can we keep one param per line here? Just nicer to read it that way.
-
-
-
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js (Diff revision 2) This does not English good.
Change Summary:
Addressed Feedback.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+329 -288) |
Checks run (2 succeeded)
-
-
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js (Diff revision 3) Missing a blank line here.