Clean up the RB.TextCommentRowSelector
Review Request #10192 — Created Oct. 3, 2018 and submitted — Latest diff uploaded
RB.TextCommentRowSelectorhas been cleaned up, modernized, and
ported to ES6. All the method documentation is now aligned with our
There were two cases of event handlers (for
which were sometimes returning
Falseto prevent the default event
from ocurring. However, this behaviour is not actually supported; the
DOM events for
mouseupdo not have
their prototypes and so the default behaviour cannot be prevented.
_copySelectionToClipboardhas been modernized to not do repeated
string concatentation. Instead it builds up an array of strings and
joins them with the detected platform's newline character.
In addition, a function that
has been pulled out into the prototype to make it clear that it does not
close over any variables in the method.
Ran JS tests.