Clean up the RB.TextCommentRowSelector
Review Request #10192 — Created Oct. 3, 2018 and submitted
The
RB.TextCommentRowSelector
has been cleaned up, modernized, and
ported to ES6. All the method documentation is now aligned with our
documentation standards.There were two cases of event handlers (for
mousedown
andmouseup
)
which were sometimes returningFalse
to prevent the default event
from ocurring. However, this behaviour is not actually supported; the
DOM events formousedown
andmouseup
do not havepreventDefault
in
their prototypes and so the default behaviour cannot be prevented.The
_copySelectionToClipboard
has been modernized to not do repeated
string concatentation. Instead it builds up an array of strings and
joins them with the detected platform's newline character.In addition, a function that
_copySelectionToClipboard
was defining
has been pulled out into the prototype to make it clear that it does not
close over any variables in the method.
Ran JS tests.
- Description:
-
The
RB.TextCommentRowSelector
has been cleaned up, modernized, andported to ES6. All the method documentation is now aligned with our documentation standards. There were two cases of event handlers (for
mousedown
andmouseup
)which were sometimes returning False
to prevent the default eventfrom ocurring. However, this behaviour is not actually supported; the DOM events for mousedown
andmouseup
do not havepreventDefault
intheir prototypes and so the default behaviour cannot be prevented. + + The
_copySelectionToClipboard
has been modernized to not do repeated+ string concatentation. Instead it builds up an array of strings and + joins them with the detected platform's newline character. + + In addition, a function that
_copySelectionToClipboard
was defining+ has been pulled out into the prototype to make it clear that it does not + close over any variables in the method. - Commit:
-
344094cd4acb9ff9fdd159669bcfa15f2d3a61bdb5eb5819b482eeda4fb3b2fa97ccdbb3efa509c7
Checks run (2 succeeded)
- Commit:
-
b5eb5819b482eeda4fb3b2fa97ccdbb3efa509c7b02625207be89a029f6b582c72c28919e73ba9c2
Checks run (2 succeeded)
- Change Summary:
-
Addressed feedback.
- Commit:
-
b02625207be89a029f6b582c72c28919e73ba9c2ebd3e6a006e5070cc05c8f6d37b88ff6b8419815