Summary

Port some JS models and tests to ES6

Review Request #10186 — Created Sept. 27, 2018 and submitted Oct. 9, 2018, 12:06 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Blocks

10136

Commit

b815c6a...

Reviewers

Groups

reviewboard

People

Description

This patch updates some of our JS models and unit tests to use ES6, as
well as updates them to meet our current documentation standards.

Testing Done

Ran JS tests.

Issues

Description	From	Last Updated
Needs to be /**	david	Oct. 3, 2018, 5:49 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Addressed comments from /r/10136/.

Commit:

505c4fd24fa659ee17d4a814eac498f1c4222d5c

fa425bcc086cb34ffaa1ab541da2abb1396a90f2

Diff:

Revision 2 (+117 -40)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/diffviewer/models/diffFileModel.js
	reviewboard/static/rb/js/diffviewer/models/diffRevisionModel.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffFileModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffRevisionModelTests.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/diffviewer/models/diffRevisionModel.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Needs to be /**
```

Change Summary:

Addressed feedback.

Commit:

fa425bcc086cb34ffaa1ab541da2abb1396a90f2

b815c6aa5da9613a5f6ee459c4f23fad8b877e04

Diff:

Revision 3 (+118 -41)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/diffviewer/models/diffFileModel.js
	reviewboard/static/rb/js/diffviewer/models/diffRevisionModel.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffFileModelTests.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffRevisionModelTests.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (afe5a2e)