Summary

Install git hooks as part of prepare-dev.py

Review Request #10182 — Created Sept. 25, 2018 and submitted Oct. 15, 2018, 1:09 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

~~10181~~

Commit

5607860...

Reviewers

Groups

reviewboard

People

Description

We now install a post-checkout git hook as part of prepare-dev.py
that will remove all .pyc files in the repository when a new ref is
checked out. This is to prevent stale .pyc files from other release
branches from sticking around when working on patches on multiple
versions of Review Board (without having to provide instructions on
setting up multiple git worktrees to developers).

Testing Done

Ran ./contrib/internal/prepare-dev.py and observed the following:

if the hook did not exist it would be created;
if the hook did exist but didn't match the content a warning was
printed; and
if the hook did exist but was non-executable it was overwritten.

Issues

Description	From	Last Updated
Add another blank line here.	david	Sept. 27, 2018, 9:14 a.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 9, 2018, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 9, 2018, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 9, 2018, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Oct. 9, 2018, 1:45 p.m.

flake8 passed.

JSHint passed.

contrib/internal/prepare-dev.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Add another blank line here.
```

Change Summary:

Addressed feedback.

Commit:

0f85742e2a4890bf119e54cd8b968929197b4f1e

c029e0e2db5d8c76ffed6f4f995d264546b46b5c

Diff:

Revision 2 (+78 -1)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebase

Commit:

c029e0e2db5d8c76ffed6f4f995d264546b46b5c

e4d17a54394d5920bd130f1ae7c5dd3c4394ec80

Diff:

Revision 3 (+92 -1)

Show changes

contrib/internal/prepare-dev.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
contrib/internal/prepare-dev.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```

Change Summary:

OOPSIE

Commit:

e4d17a54394d5920bd130f1ae7c5dd3c4394ec80

5607860269dc32b0f79d870f0390291a362abdfc

Diff:

Revision 4 (+83 -1)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (24791a5)