Summary

Add an --only flag to disable features by default

Review Request #10181 — Created Sept. 25, 2018 and submitted Oct. 15, 2018, 1:09 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

~~10180~~

Blocks

10182

Commit

d39551f...

Reviewers

Groups

reviewboard

People

Description

Our previous workflow for running a specific set of prepare-dev.py was
to to pass an argument for each section we did not want to run. e.g., to
run only the dependency installation, you would run:

./contrib/internal/prepare-dev.py --no-db --no-media.

That is, each action was enabled by default and you had to disable
everything you didn't want to run. As more features get added to
prepare-dev.py, it becomes less user friendly to force the user to
specify the complement of the features that they don't want to run.

Now we have an --only option which inverts our usual behaviour. In
other words, to run only the dependency installation as above, you
would run

./contrib/internal/prepare-dev.py --only --deps

This allows the user to more easily specify and run a minimal part of
prepare-dev.py's actions, as opposed to the old behaviour which
assumed you wanted to run a maximal part of its actions.

Testing Done

Ran ./contrib/internal/prepare-dev.py --only --deps and only deps
were installed.

Issues

Description	From	Last Updated
Typo in summary: feautres	david	Sept. 26, 2018, 1:01 p.m.
Typos in description: depenency compliment installtion	david	Sept. 28, 2018, 11:25 a.m.
Can you do one per line? Same below.	chipx86	Oct. 9, 2018, 1:42 p.m.
I feel like this could be a bit more specific in its behavior. How about: Disable all features by default …	chipx86	Oct. 9, 2018, 1:42 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Correct the set of attrs.

Commit:

-	165c8ce0249e44c678c23d94cfb0ebf22d802207
+	0a57fd41134753de7d03e95d39770b61457e1660

Diff:

Revision 2 (+27 -4)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Typo in summary: feautres
```

Summary:

-	Add an --only flag to disable feautres by default
+	Add an --only flag to disable features by default

```
Ship It!
```

The issue has been resolved. Show all issues

Typos in description:

depenency
compliment
installtion

Change Summary:

Address feedback.

Description:

		Our previous workflow for running a specific set of `prepare-dev.py` was
		to to pass an argument for each section we did not want to run. e.g., to
~		run only the depenency installation, you would run:
	~	run only the dependency installation, you would run:



		`./contrib/internal/prepare-dev.py --no-db --no-media.`




		That is, each action was enabled by default and you had to disable
		everything you didn't want to run. As more features get added to
		`prepare-dev.py`, it becomes less user friendly to force the user to
~		specify the compliment of the features that they don't want to run.
	~	specify the complement of the features that they don't want to run.

		Now we have an `--only` option which inverts our usual behaviour. In
~		other words, to run only the dependency installtion as above, you would
~		run
	~	other words, to run only the dependency installation as above, you
	~	would run



		`./contrib/internal/prepare-dev.py --only --deps`




		This allows the user to more easily specify and run a minimal part of
		`prepare-dev.py`'s actions, as opposed to the old behaviour which
		assumed you wanted to run a maximal part of its actions.

contrib/internal/prepare-dev.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you do one per line?
Same below.
```

contrib/internal/prepare-dev.py (Diff revision 2)

The issue has been resolved. Show all issues

I feel like this could be a bit more specific in its behavior. How about:

Disable all features by default (implying --no-* for each option) unless specifically enabled (.e.g, --media --deps)

Change Summary:

Addressed feedback.

Commit:

-	0a57fd41134753de7d03e95d39770b61457e1660
+	d39551fb4ce69e2a7bdce69888e4038e9c1753f8

Diff:

Revision 3 (+67 -12)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (7878cec)