flake8
-
contrib/internal/prepare-dev.py (Diff revision 1) Show all issues
Review Request #10179 — Created Sept. 25, 2018 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-2.5.x | |
10180 | |
62a2eef... | |
Reviewers | |
reviewboard | |
Our prepare-dev.py was doing quite a few things that weren't best
practices:
options
.optparse
module instead of argparse
.These issues have all been addressed. Where we were previously using
global mutable state we now pass our state as an argument to the
function that requires it (create_settings
). Our argument parser has
been updated to use argparse.ArgumentParser
. The module and all
functions now have docstrings that meet our documentation guidelines.
Additionally, I cleaned up control flow a bit in main()
where things
were running in a try..except
that didn't need to.
Ran
prepare-dev.py
and it ran correctly.
Description | From | Last Updated |
---|---|---|
E303 too many blank lines (2) |
![]() |
|
It's kind of weird to have this be this late. I know we had a few people run into issues … |
|
|
typo: cmdling |
|
|
I think this can just be "Parse the command-line arguments". Creating an argument parser is just an implementation detail that … |
|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+72 -46) |
contrib/internal/prepare-dev.py (Diff revision 2) |
---|
It's kind of weird to have this be this late. I know we had a few people run into issues where trying to import
reviewboard.cmdline.rbsite
failed because there were missing dependencies. Can we move this up to be the first thing in the file?
Addressed feedback
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+74 -47) |
contrib/internal/prepare-dev.py (Diff revision 3) |
---|
I think this can just be "Parse the command-line arguments". Creating an argument parser is just an implementation detail that doesn't have any side effects.
Addressed feedback
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+74 -47) |