Work around different versions of patch(1) in unit tests
Review Request #10164 — Created Sept. 22, 2018 and submitted
Information | |
---|---|
brennie | |
Review Board | |
release-4.0.x | |
f3b1cc3... | |
Reviewers | |
reviewboard | |
We had a unit test that depended on the specific version of
patch(1)
installed. Newer versions of patch will accept a diff that contains no
hunks, whereas older versions will fail with a message saying that the
input contained only garbage.We now have unit tests that check the correct behaviour happens in both
cases by replacing our call topatch(1)
.
Ran unit tests.
-
-
-
reviewboard/diffviewer/tests/test_diffutils.py (Diff revision 1) Should this be a test assertion rather than using the
assert
keyword?
Description: |
|
---|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+76 -2) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.