Summary

Work around different versions of patch(1) in unit tests

Review Request #10164 — Created Sept. 22, 2018 and submitted Oct. 3, 2018, 6:15 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

f3b1cc3...

Reviewers

Groups

reviewboard

People

Description

We had a unit test that depended on the specific version of patch(1)
installed. Newer versions of patch will accept a diff that contains no
hunks, whereas older versions will fail with a message saying that the
input contained only garbage.

We now have unit tests that check the correct behaviour happens in both
cases by replacing our call to patch(1).

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
In your description, "replacing out call to patch(1)" doesn't sound quite right, grammatically.	david	Sept. 22, 2018, 10:07 a.m.
Should this be a test assertion rather than using the assert keyword?	david	Sept. 22, 2018, 10:09 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

In your description, "replacing out call to patch(1)" doesn't sound quite right, grammatically.

reviewboard/diffviewer/tests/test_diffutils.py (Diff revision 1)

The issue has been resolved. Show all issues

Should this be a test assertion rather than using the assert keyword?

Description:: We had a unit test that depended on the specific version of patch(1)
installed. Newer versions of patch will accept a diff that contains no
hunks, whereas older versions will fail with a message saying that the
input contained only garbage.

We now have unit tests that check the correct behaviour happens in both
~ cases by replacing out call to patch(1).
~ cases by replacing our call to patch(1).

Commit:

df425f4109d31f6836d8eeb0be283075720d43c8

f3b1cc38a3fd3ba64e8901c0a07e9067e49793e6

Diff:

Revision 2 (+76 -2)

Show changes

reviewboard/diffviewer/tests/test_diffutils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (c76b74f)

		We had a unit test that depended on the specific version of `patch(1)`
		installed. Newer versions of patch will accept a diff that contains no
		hunks, whereas older versions will fail with a message saying that the
		input contained only garbage.

		We now have unit tests that check the correct behaviour happens in both
~		cases by replacing out call to `patch(1)`.
	~	cases by replacing our call to `patch(1)`.