- Status:
- Discarded
Fixes the blank space visible in the infobox when avatars are disabled.
Review Request #10160 — Created Sept. 21, 2018 and submitted
When avatars are disabled a blank space was visible on the infobox
where the avatar should be.The code before checked if the avatar service was enabled and would
then make a request to gravatar. Now the code will check if avatar
services are enabled and if there is an avatar set.
If the services are disabled you will there will be no space
for an avatar. Otherwise, you will see a default avatar.
Python and JavaScript tests were passed.
Tested inside of Firefox and Chrome in 2 scenarios
1. Enabling avatars
2. Disabling avatars
| Description | From | Last Updated |
|---|---|---|
|
Please see screenshot number 3 below Thanks for supplying screenshots! That really clears up what the end user experience will … |
 mike_conley
|
|
|
Can you update the summary to use proper capitalization? ("the infobox" -> "The infobox"). |
 david
|
|
|
Please put the associated bug number into the "Bugs" field. |
david
|
|
|
Please wrap your description to 72 columns (this gets turned into the commit message) |
david
|
|
|
Can you write your commit summary in the imperitive mood, i.e., as if it were a command. The following sentence … |
 brennie
|
|
|
Please undo all the indentation changes your editor auto-"fixed". |
brennie
|
|
|
I think we have a convention of keeping the template tags that open on a newline unindented, but indenting the … |
mike_conley
|
- Status:
- Re-opened
- Description:
-
~ the infobox has been updated so that it doesn't display a blank space on the avatar
~ When avatars are disabled a blank space was visible on the infobox where the avatar should be. Please see screenshot number 3 below.
+ + The code before checked if the avatar service was enabled and would then make a request to gravatar. Now the code will check if avatar services are enabled and if there is an avatar set. If the services are disabled you will see screenshot 1. If avatar services are enable then you will see Screenshot 2.
- Testing Done:
-
+ Python and JavaScript tests were passed.
+ + Tested inside of Firefox and Chrome in 2 scenarios
+ 1. Enabling avatars + 2. Disabling avatars - Commit:
-
b5ea5263150e31528702b61266dfe69099339fa7
- Diff:
-
Revision 1 (+54 -47)
- Added Files:
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Please see screenshot number 3 belowThanks for supplying screenshots! That really clears up what the end user experience will be like.
However, we use the Description and Testing Done sections to construct the final commit messages, and the commit will not include those screenshots. Can you please remove the reference to screenshots (since it won't be available in the commit message)?
-
I think we have a convention of keeping the template tags that open on a newline unindented, but indenting the internal bits. So I think we prefer:
{% if foo %} {% if bar %} {% endif %} {% endif %}instead of:
{% if foo %} {% if bar %} {% endif %} {% endif %}So can you please reformat this file to the original indentation style?
- Summary:
-
the infobox has been updated so that it doesn't display a blank space on the avatarThe infobox has been updated so that it doesn't display a blank space on the avatar
- Description:
-
~ When avatars are disabled a blank space was visible on the infobox where the avatar should be. Please see screenshot number 3 below.
~ When avatars are disabled a blank space was visible on the infobox where the avatar should be.
~ The code before checked if the avatar service was enabled and would then make a request to gravatar. Now the code will check if avatar services are enabled and if there is an avatar set. If the services are disabled you will see screenshot 1. If avatar services are enable then you will see Screenshot 2.
~ The code before checked if the avatar service was enabled and would then make a request to gravatar. Now the code will check if avatar services are enabled and if there is an avatar set. If the services are disabled you will there will be no space for an avatar. Otherwise, you will see a default avatar.
- Bugs:
- Description:
-
~ When avatars are disabled a blank space was visible on the infobox where the avatar should be.
~ When avatars are disabled a blank space was visible on the infobox
+ where the avatar should be. ~ The code before checked if the avatar service was enabled and would then make a request to gravatar. Now the code will check if avatar services are enabled and if there is an avatar set. If the services are disabled you will there will be no space for an avatar. Otherwise, you will see a default avatar.
~ The code before checked if the avatar service was enabled and would
+ then make a request to gravatar. Now the code will check if avatar + services are enabled and if there is an avatar set. + If the services are disabled you will there will be no space + for an avatar. Otherwise, you will see a default avatar.
