Make CppLint optional and update documentation

Review Request #10159 — Created Sept. 21, 2018 and submitted

ilaw
ReviewBot
master
55a997b...
reviewbot, students

Before this change, ReviewBot would try to install CppLint whether or not the user required it. This change removes CppLint from the required dependencies and creates an optional target 'all' that installs CppLint. This target can be extended in the future to include other dependencies.

This change also updates the CppLint installation documentation to tell the user that they will need to manually install CppLint to use it.

pip install -e ./bot does not install CppLint
pip install -e ./bot[all] installs CppLint

Description From Last Updated

Can you rewrite your summary in the imperative mood, i.e., as a command or an order. If you substitute your ...

brenniebrennie

Can you limit your summary to 50 characters?

brenniebrennie

I know this is a super short patch, but can you take a look at our guide on writing change ...

brenniebrennie
mike_conley
  1. Looks good to me! Thanks, Iris!

  2. 
      
brennie
  1. 
      
  2. Can you rewrite your summary in the imperative mood, i.e., as a command or an order.

    If you substitute your summary into the following sentence, it should make sense:

    "This patch will <summary>"

    e.g., Made -> Make

  3. Can you limit your summary to 50 characters?

  4. I know this is a super short patch, but can you take a look at our guide on writing change descriptions and flesh our your summary to use full sentences with periods, etc.?

  5. 
      
ilaw
david
  1. Ship It!
  2. 
      
ilaw
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (a07318f)
Loading...