flake8
passed.
JSHint
passed.
Make CppLint optional and update documentation
Review Request #10159 — Created Sept. 21, 2018 and submitted
Before this change, ReviewBot would try to install CppLint whether or not the user required it. This change removes CppLint from the required dependencies and creates an optional target 'all' that installs CppLint. This target can be extended in the future to include other dependencies.
This change also updates the CppLint installation documentation to tell the user that they will need to manually install CppLint to use it.
pip install -e ./bot does not install CppLint
pip install -e ./bot[all] installs CppLint
| Description | From | Last Updated |
|---|---|---|
|
Can you rewrite your summary in the imperative mood, i.e., as a command or an order. If you substitute your … |
 brennie
|
|
|
Can you limit your summary to 50 characters? |
brennie
|
|
|
I know this is a super short patch, but can you take a look at our guide on writing change … |
brennie
|
-
-
Can you rewrite your summary in the imperative mood, i.e., as a command or an order.
If you substitute your summary into the following sentence, it should make sense:
"This patch will <summary>"
e.g., Made -> Make
-
-
I know this is a super short patch, but can you take a look at our guide on writing change descriptions and flesh our your summary to use full sentences with periods, etc.?
- Summary:
-
Made cpplint an optional dependency and updated cpplint install documentationMake CppLint optional and update documentation
- Description:
-
~ Make CppLint an optional dependency in setup.py
~ Update CppLint documentation ~ Before this change, ReviewBot would try to install CppLint whether or not the user required it. This change removes CppLint from the required dependencies and creates an optional target 'all' that installs CppLint. This target can be extended in the future to include other dependencies.
~ + This change also updates the CppLint installation documentation to tell the user that they will need to manually install CppLint to use it.
