flake8
failed.
JSHint
passed.
Make buildbot an optional dependency under all
Review Request #10156 — Created Sept. 21, 2018 and submitted
The new "all" optional dependency target is intended to replicate the
old behavior of installing all python dependencies.Documentation has been updated to reflect this.
Since this is just a change for pip dependencies I've done:
- pip install -e ./bot
- pip install -e ./bot[all]To test if it installs and doesn't install buildbot under the default
package and the "all" target, and according to the logs this is the case.
| Description | From | Last Updated |
|---|---|---|
|
Can you rewrite your summary to be in the imperitive mood, i.e., as if it were a command or an … |
 brennie
|
|
|
Your pip commands aren't correct and shouldn't work. Doing the following: pip install -e ./bot reviewbot-worker will attempt to install … |
brennie
|
|
|
F821 undefined name 'is_exe_in_path' |
 reviewbot
|
- Commit:
-
ecc2b233754a52a210449ec9069266fb29b92bb7eec4285c2f9ea6af000a2066eff885999c1f4dd4
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Can you rewrite your summary to be in the imperitive mood, i.e., as if it were a command or an order.
If you substitute your summary into the following sentence it should make sense:
This patch will <summary>e.g., remove the "EasyFix:" prefix.
-
Your pip commands aren't correct and shouldn't work.
Doing the following:
pip install -e ./bot reviewbot-workerwill attempt to install BOTH the package in
./botANDreviewbot-worker(i.e., from PyPI).To install the worker with all dependencies you should do
pip install -e ./bot[all]
- Summary:
-
EasyFix: Make buildbot an optional dependency under allMake buildbot an optional dependency under all
- Testing Done:
-
Since this is just a change for pip dependencies I've done:
~ - pip install -e ./bot reviewbot-worker ~ - pip install -e ./bot reviewbot-worker[all] ~ To test if it installs and doesn't install buildbot under the default ~ - pip install -e ./bot ~ - pip install -e ./bot[all] ~ + To test if it installs and doesn't install buildbot under the default
package and the "all" target, and according to the logs this is the case.
