Make buildbot an optional dependency under all

Review Request #10156 — Created Sept. 21, 2018 and submitted

ammar
ReviewBot
master
eec4285...
reviewbot, students

The new "all" optional dependency target is intended to replicate the
old behavior of installing all python dependencies.

Documentation has been updated to reflect this.

Since this is just a change for pip dependencies I've done:
- pip install -e ./bot
- pip install -e ./bot[all]

To test if it installs and doesn't install buildbot under the default
package and the "all" target, and according to the logs this is the case.

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

ammar
brennie
  1. 
      
  2. Your pip commands aren't correct and shouldn't work.

    Doing the following:

    pip install -e ./bot reviewbot-worker
    

    will attempt to install BOTH the package in ./bot AND reviewbot-worker (i.e., from PyPI).

    To install the worker with all dependencies you should do

    pip install -e ./bot[all]

  3. Can you rewrite your summary to be in the imperitive mood, i.e., as if it were a command or an order.

    If you substitute your summary into the following sentence it should make sense:

    This patch will <summary>
    

    e.g., remove the "EasyFix:" prefix.

  4. 
      
ammar
brennie
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
ammar
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (e893372)
Loading...