Summary

Make setup.py consistent across all versions

Review Request #10138 — Created Sept. 6, 2018 and submitted Sept. 18, 2018, 4:27 p.m.

Owner

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

6f406d4...

Groups

People

Description

This patch backports newer, cleaner methods we are using in release-2.0-x to
release-0.9.x.

Additionally, the ListNodeDependenciesCommand mistakenly had the wrong option
name. This has been rectified.

Testing Done


Ran setup.py list_node_deps
Ran setup.py develop

Issues

Description	From	Last Updated
Typo in summary: verisons -> versions	david	Sept. 6, 2018, 6:36 p.m.
release-0.9.x doesn't have README.rst	david	Sept. 7, 2018, noon

flake8 passed.

JSHint passed.

~		The `ListNodeDependenciesCommand` mistakenly has the wrong option name.
~		Additionally, on Python2, distutils requires `Command.boolean_options`
	~	This patch backports newer, cleaner methods we are using in release-2.0-x to
	~	release-0.9.x.
-		to be a list of `str` (`bytes`), so we now use `unicode_literals` and
-		intentionally make the `boolean_options` a list of bytestrings for
-		clarity.

~		This makes setup.py consistent across release-0.9.x to release-2.0.x
	~	Additionally, the `ListNodeDependenciesCommand` mistakenly had the wrong option
	+	name. This has been rectified.