flake8
failed.
JSHint
passed.
flake8
-
reviewboard/accounts/forms/auth.py (Diff revision 1) Show all issues -
reviewboard/accounts/middleware.py (Diff revision 1) E127 continuation line over-indented for visual indent
Review Request #10131 — Created Aug. 28, 2018 and submitted
Information | |
---|---|
jcannon | |
Review Board | |
release-3.0.x | |
85f19bb... | |
Reviewers | |
reviewboard | |
Adding a custom X509 username field.
This will allow for configurations that use other front-ends for authentication. One example might be mod_auth_mellon for SAML SSO support (which sets MELLON_NAME_ID).
Not sure how to inject
settings
intest_x509_auth_middleware tests
to test "CUSTOM".
Tested on a copy of our reviewboard server which uses mod_auth_mellon and references our SSO server. Works like a charm!
reviewboard/accounts/forms/auth.py (Diff revision 1) |
---|
reviewboard/accounts/middleware.py (Diff revision 1) |
---|
E127 continuation line over-indented for visual indent
Pleasing flake8
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+43 -27) |