Summary

Adding a custom X509 username field

Review Request #10131 — Created Aug. 28, 2018 and submitted Feb. 4, 2019, 2:58 p.m.

Information

Owner

jcannon

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

85f19bb...

Reviewers

Groups

reviewboard

People

Description

Adding a custom X509 username field.

This will allow for configurations that use other front-ends for authentication. One example might be mod_auth_mellon for SAML SSO support (which sets MELLON_NAME_ID).

Testing Done

Not sure how to inject settings in test_x509_auth_middleware tests to test "CUSTOM".
Tested on a copy of our reviewboard server which uses mod_auth_mellon and references our SSO server. Works like a charm!

Issues

Description	From	Last Updated
E501 line too long (113 > 79 characters)	reviewbot	Aug. 28, 2018, 2:41 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Aug. 28, 2018, 2:41 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/forms/auth.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (113 > 79 characters)
```
reviewboard/accounts/middleware.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```