API method to get the diffsets of a review request
Review Request #1013 — Created Sept. 1, 2009 and submitted
Currently there is no support for this. But it's needed for clients who are interested in the diffs of a review request.
Includes a test.
Looks good. Let us know your github username and we'll set you up with commit access.
Nice patch; I just did the same thing myself and was getting ready to submit it for review! I have seen http 500 errors if you call "review_request.diffset_history.diffsets.all()" or ".latest()", and there are no diffsets. The existing code typically does the following: public_diffsets = review_request.diffset_history.diffsets if public_diffsets.count() > 0: ... My original code didn't have that code and was throwing 500 on some review requests. I added that "count() > 0" check and haven't seen one since. Christian, can you comment on whether this should be added? Thanks all!