Correctly return line counts in the FileDiffCollectionMixin

 






 

 


  Review Request #10099
  —
  Created July 24, 2018 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 









 
 

  10094
 









 
 

  b2f5893...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The FileDiffCollectionMixin incorrectly assumed that counts would

always be integers. However, before chunks are generated, some line

counts may be None. This patch works around that limitation and

returns the correct result for that case. Unit tests have been added to

test this behaviour.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 3


This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

    

 

 

 

 
orig
1
2
3
4

 



    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/models/mixins.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_models_mixins.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...