flake8
passed.
JSHint
passed.
Review Request #10090 — Created July 16, 2018 and updated
Review Board normalizes line endings to LF. This is a problem on Windows
where files have CRLF line endings. A downloaded raw diff file should
have the same line endings as the uploaded diff.Bugs closed: 2916
Sucessfully ran unit tests.
Testing Done: |
|
---|
Testing Done: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+69 -3) |
fix
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+69 -3) |
reviewboard/diffviewer/models.py (Diff revision 3) |
---|
The
DileDiff.diff
property is not only called when downloading diffs. Is this a problem? Alternatively, we could introduce a new property.