Clean up git client type.

Review Request #10086 — Created July 14, 2018 and submitted

david
RBTools
release-1.0.x
6dea6bc...
rbtools

When we detect what type of git checkout we're dealing with (plain git,
git-svn, or git-p4), that would get assigned to a public attribute with a
string type. This change fixes things so it's a private attribute with
symbols instead.

Ran unit tests.

Description From Last Updated

We could also use enum34 on python 2.x and use an enum.Enum here.

brenniebrennie
brennie
  1. Either way, I'm good with this. Nice cleanup!

  2. rbtools/clients/git.py (Diff revision 1)
     
     
     
     

    We could also use enum34 on python 2.x and use an enum.Enum here.

    1. I don't think it's worth pulling in a new dependency just for this.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (70339f3)
Loading...