Summary

Fix Review Bot when running against Review Board 3.0.8+

Review Request #10080 — Created July 13, 2018 and submitted July 20, 2018, 9:42 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-1.0.x

Bugs

Depends On

Commit

f2c6f9f...

Reviewers

Groups

reviewbot

People

Description

In Review Board 3.0.8, we split all the auth backends into their own
modules. This works in most cases, but Review Bot manually assigns a
backend path when creating the session key. This failed because that
path is used to index into a dict of loaded backends within the django
auth middleware.

This fix adds a manual version check to ensure we set the correct auth
backend path for each version.

Testing Done

Was able to properly detect the worker nodes.

Issues

Description	From	Last Updated
While this works, I wonder if we should just not hard-code a path and instead do: from reviewboard.accounts.backends import auth_backends …	chipx86	July 17, 2018, 4:56 p.m.
E501 line too long (87 > 79 characters)	reviewbot	July 13, 2018, 11:55 a.m.

flake8 failed.

JSHint passed.

flake8

extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (87 > 79 characters)
```

Commit:

-	7df2e5f592d36f170467e72b2a25ad5635e6cd68
+	fa334b883b4aceed58827ddd3b1f72a1811e864b

Diff:

Revision 2 (+12 -1)

Show changes

extension/reviewbotext/extension.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (ecb13c2)

Status: Re-opened

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

While this works, I wonder if we should just not hard-code a path and instead do:

from reviewboard.accounts.backends import auth_backends

...

backend_cls = auth_backends.get_auth_backend('builtin')
user.backend = '%s.%s' % (backend_cls.__module__, backend_cls.__name__)

Commit:

-	fa334b883b4aceed58827ddd3b1f72a1811e864b
+	f2c6f9ffdbdfeeed17efaef52053a6095319e610

Diff:

Revision 3 (+10 -1)

Show changes

extension/reviewbotext/extension.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (78bc200)