Fix type of prompts passed to getpass.

Review Request #10076 — Created July 9, 2018 and submitted

david
RBTools
release-1.0.x
4711
635fe73...
rbtools

The updates for unicode and Python 3 in RBTools 1.0 changed the type of
the string passed into getpass from a bytestring to unicode.
Unfortunately, with Python 2.7 on Windows, this fails. This change fixes
all callers up to pass in str instead, which should work correctly for
both Python 2.7 and 3.x.

Verified that getpass worked correctly (on Linux). My Windows
environment isn't in a usable state right now.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
david
chipx86
  1. 
      
  2. Change looks fine, but given how many call sites there are, and that we have get_input() already, maybe we should either add a get_pass() or a parameter to get_input() that does this for us.

  3. 
      
david
Review request changed

Commit:

-5b6cf6de0b1de822c599e983980713e52e710fd8
+ecfd9466b705be25a958fce4b6593a8568300f50

Diff:

Revision 2 (+21 -9)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
brennie
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (82ce727)
Loading...