Summary

Fix type of prompts passed to getpass.

Review Request #10076 — Created July 9, 2018 and submitted July 12, 2018, 4:29 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-1.0.x

Bugs

4711

Depends On

Commit

635fe73...

Reviewers

Groups

rbtools

People

Description

The updates for unicode and Python 3 in RBTools 1.0 changed the type of
the string passed into getpass from a bytestring to unicode.
Unfortunately, with Python 2.7 on Windows, this fails. This change fixes
all callers up to pass in str instead, which should work correctly for
both Python 2.7 and 3.x.

Testing Done

Verified that getpass worked correctly (on Linux). My Windows
environment isn't in a usable state right now.

Issues

Description	From	Last Updated
Change looks fine, but given how many call sites there are, and that we have get_input() already, maybe we should …	chipx86	July 10, 2018, 2:19 p.m.
F821 undefined name 'getpass'	reviewbot	July 10, 2018, 2:22 p.m.

flake8 passed.

JSHint passed.

Bugs:: 4711

The issue has been resolved. Show all issues

Change looks fine, but given how many call sites there are, and that we have get_input() already, maybe we should either add a get_pass() or a parameter to get_input() that does this for us.