Adding 'drop_open_issues' to StatusUpdate

Review Request #10075 — Created July 9, 2018 and updated

jcannon
Review Board
master
10061
9494233...
reviewboard

Adding 'drop_open_issues' to StatusUpdate.

This feature is needed by the Review Bot feature "Adding ability to drop old issues on new review." https://reviews.reviewboard.org/r/10061/.
The method finds all open issues associated with the status update's review (if it exists) and drops them. Smart enough to update the review request's timestamp and issues counts.

Unit tests!

Also, called the method (via the Review Bot changes) with a review request with previous status updates with open issues. Noticed the timestamp and issue count were correct, and old issues were dropped.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
jcannon
  1. I'll start on unit tests tomorrow.

    1. I didn't see any test files that test the StatusUpdate model (I see other ones for the Entry). (That makes sense because there wasn't much logic in StatusUpdate before).
      I plan on adding one, stop me if I'm way off track.

  2. 
      
jcannon
Review request changed

Change Summary:

Adding unit tests

Testing Done:

~  

Call the method (via the Review Bot changes) with a review request with previous status updates with open issues. Noticed the timestamp and issue count were correct, and old issues were dropped.

  ~

Unit tests!

  +
  +

Also, called the method (via the Review Bot changes) with a review request with previous status updates with open issues. Noticed the timestamp and issue count were correct, and old issues were dropped.

Commit:

-f842ea8e6475d07269280a0a320f5a070692513e
+b9e6631344294549686009178673b8a2c9799c5b

Diff:

Revision 2 (+168 -1)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

jcannon
Review request changed

Change Summary:

Fixed line length

Commit:

-b9e6631344294549686009178673b8a2c9799c5b
+94942339a26af4d122fb4fb9dc1b077bbd5f5759

Diff:

Revision 3 (+169 -1)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...