flake8
passed.
JSHint
passed.
Adding 'drop_open_issues' to StatusUpdate
Review Request #10075 — Created July 9, 2018 and submitted
Adding 'drop_open_issues' to StatusUpdate.
This feature is needed by the Review Bot feature "Adding ability to drop old issues on new review." https://reviews.reviewboard.org/r/10061/.
The method finds all open issues associated with the status update's review (if it exists) and drops them. Smart enough to update the review request's timestamp and issues counts.
Unit tests!
Also, called the method (via the Review Bot changes) with a review request with previous status updates with open issues. Noticed the timestamp and issue count were correct, and old issues were dropped.
| Description | From | Last Updated |
|---|---|---|
|
This should also be done on release-3.0.x instead of master. Can you rebase? |
 david
|
|
|
E501 line too long (81 > 79 characters) |
 reviewbot
|
|
|
We should import this from reviewboard.reviews.models.base_comment, to avoid potential circular import problems. |
david
|
|
|
Please add this line back |
david
|
|
|
There's an extra space after the """, and this should be written in the imperative rather than passive mood ("Drop … |
david
|
|
|
I know a lot of old code doesn't have it, but can you add a module docstring here? |
david
|
|
|
Can you specify that this is dropping open issues associated with a status update? |
david
|
|
|
Same here. |
david
|
|
|
Same here. |
david
|
|
|
Same here. |
david
|
|
|
Same here. |
david
|
|
|
Same here. |
david
|
Change Summary:
Adding unit tests
Testing Done: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||
Diff: |
Revision 2 (+168 -1) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/reviews/tests/test_status_update.py (Diff revision 2) E501 line too long (81 > 79 characters)
Change Summary:
Fixed line length
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+169 -1) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/reviews/models/status_update.py (Diff revision 3) We should import this from
reviewboard.reviews.models.base_comment, to avoid potential circular import problems. -
-
reviewboard/reviews/models/status_update.py (Diff revision 3) There's an extra space after the
""", and this should be written in the imperative rather than passive mood ("Drop open issues" instead of "Drops open issues") -
reviewboard/reviews/tests/test_status_update.py (Diff revision 3) I know a lot of old code doesn't have it, but can you add a module docstring here?
-
reviewboard/reviews/tests/test_status_update.py (Diff revision 3) Can you specify that this is dropping open issues associated with a status update?
-
-
-
-
-
