Gracefully handling unselected tool

Review Request #10064 — Created July 3, 2018 and submitted

jcannon
ReviewBot
master
4713
87f5b91...
reviewbot

If a tool was not selected (i.e. user left the dropdown at "---------") when the user saves the tool, the server would result in an Internal Error.

This was due to the fact that we weren't handling the "empty" case when attempting to get the data from the widget.

Now we handle the empty case, which returns no data.

Create new configuration, or edit config:
- No name + no tool -> both error
- Name + no tool -> tool errors

Selecting a valid tool makes the error go away.

Error is "This field is required."

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
jcannon
david
  1. 
      
  2. Can you flesh out the description some? Without looking at the linked bug I can't tell what this change is trying to accomplish. Because the description will turn into the commit message, we want it to explain what the problem was and how this change fixes it.

    See https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for our general guidelines on this.

  3. 
      
jcannon
david
  1. Ship It!
  2. 
      
jcannon
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (8867ce1)
Loading...